Repository navigation
Docs - DOCS - Rewrite the user documentation around the pipeline, its physics and its outputs - #636
Merged
Merged
Conversation
…module nav by pipeline Rebuild workflow.md as the physics-first map of every stage main runs, with a which-stage-do-I-need table, headline-output definitions, the complete deck section index, all example directories and the output-file groups. Give index.md a short stage table that points into it. Collapse set_up.md to one install procedure for Linux, macOS and WSL with the correct repository URL and a first run that reads three datasets; move its developer tips to developer_notes.md. Rename the "API Reference" nav group to "Modules" in pipeline order. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
…rturbed equilibrium pages around their physics Give stability.md a what-it-computes opener, structural governing equations with the explicit (m - nq) convention, an outputs table and a short domain and layer-overlap section in place of the integrator and diffusivity essays; the per-surface Delta-prime stub and the Notes that contradicted the example go. Make ballooning.md the Local Stability page: criteria, condensed ballooning theory, the run and outputs block moved from stability.md, and numerical notes without the equivalence proof or the implementation history. Correct the Glasser 2016 article numbers on the Galerkin page, state the Q convention once and add its deck snippet and outputs. Prepend the response physics (P, L, reluctance, resonant field, islands, Chirikov, energies) and a units table to perturbed_equilibrium.md. Add the LocalStability citations, move the SLAYER diffusivity inputs to the Tearing page, and fix the Match and Tearing prerequisites on the workflow page. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
…, inputs and outputs Give kinetic_forces.md the NTV physics, the torque methods, the collision and distribution options, a deck snippet and an outputs table, and drop the Fortran line-number warning; move the kinetic file schema and ion composition to equilibrium.md, which gains a format table, a condensed radial-grid section and an outputs table. Resolve the coil normalization statement on forcing_terms.md (the Biot-Savart pipeline produces the unit-norm flux directly) and condense the page. Rebuild inner_layer.md as the Tearing page: outer-inner matching, SLAYER and GGJ, the dispersion search, the critical resonant field, a deck snippet, outputs, and the solver internals and benchmarks as numerical notes. Give error_fields.md a workflow list, drop the stale "later releases" sentence and condense the sampling, convergence, correction-design and naming sections. Give vacuum.md the vacuum energy, the wall shapes and the outputs. Correct the DIIID-like_ideal_example deck header, which named itself the Delta-prime fixture. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
…s and drop the unreferenced figures Condense conventions.md to a reference page with the field-amplitude material merged into one section, the mode-range attribution corrected and the rotation conventions kept; rebuild api.md around the pipeline script, a stage table and the rerun paragraph; trim analysis.md, utilities.md and developer_notes.md, which loses the Delta-prime plateau investigation and the sample harness output; name the citation sections by module and move every link to the new anchors; condense the tolerance, Monte Carlo subset and coil-revision prose of error_fields.md; delete the figures no page references, with their scripts and manifest entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
…esponse prerequisites and tidy the module pages Retype the perturbed_equilibrium.md governing equations that control characters had corrupted, and restructure its trailing sections and error_fields.md onto the shared page skeleton with an outputs table and citation links. State on the workflow, index, stability, Galerkin, perturbed equilibrium and API pages that the plasma response needs a Forward solve without a wall, so a response deck and a Delta-prime or wall deck are separate runs. Give the laboratory toroidal angle its own symbol, display the NTV torque integral, fix the critical-field viscosity wording, move the GGJ defaults to the Tearing page, sweep heading case and link text to the nav titles, add the SPARC and ARC correction-limit papers to the citations, and align the README opening and the documentation template with the page skeleton. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
Collaborator
|
@logan-nc I am working on this FYI. You should take a look when you wake up and also at the two small tweak PRs I requested your review on and assigned to you, merge them when you are happy. |
…mages, fix SLAYER attributions and SPARC/ARC paper titles
Conflicts in the rewritten pages are resolved toward the new structure, with develop's additions moved in: the kinetic-file rates columns and kinetic_format to the Equilibrium page, supplied collision rates to Kinetic Forces, the multi-n coupling SVD and the five coupling matrices to Perturbed Equilibrium, the laboratory direction of omega_E and the BounceAveraging pointer to Conventions, and the kinetic and wall snapshot to the Workflow output table. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014wKUyAaxKdTJ5ch1boMFE1
… the README opening, and document replays and the Fortran map Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186CLfjeJeSusNTva5RMfGU
Collaborator
Author
|
@matt-pharr: I pushed 332d400 on top of your develop merge (c5e1287). It only adds text or edits lines you hadn't touched; I left your fixes alone. This comes from my review plus an independent pass by a second Claude agent, with each claim checked against
Open questions:
|
…l a matched result can drive the response The deck added coil forcing and [PerturbedEquilibrium] to DIIID-like_gal_resistive_example, a stage that stops on a Galerkin or matched result, and its harness case stripped both sections and tracked only N/A. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186CLfjeJeSusNTva5RMfGU
…se from a matched result Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186CLfjeJeSusNTva5RMfGU
matt-pharr
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
src/changes)The user documentation now leads with the pipeline and its physics. Every module page has the same layout: what it computes, the governing equations, how to run it, its outputs, numerical notes, and the API. Long passages about implementation details and project history are gone. The setup guide, the workflow map and several pages had factual errors, which are fixed.
What the goal was
The audience is physics PhD users. In the old pages, AI-written passages often ran for paragraphs on minor details (edge cases, numerical trivia, what used to be wrong), while the overall workflow and the core physics got little space. This pass rebalances that and standardizes the language.
How it was done:
docs/srcwent from 5200 to 2564 lines.What changed, by page
workflow.mdmainruns, with a "which stage do I need" table that gives thegpec.h5paths, a card per stage, a deck-section index and all examplesset_up.mdOpenFUSIONToolkit/GPEC); first run and reading the outputsindex.mdstability.mdballooning.md→ Local Stabilitygalerkin.mdperturbed_equilibrium.mdkinetic_forces.mdforcing_terms.mderror_fields.mdinner_layer.md→ Tearingequilibrium.md,vacuum.md,conventions.md,api.md,analysis.md,utilities.md,developer_notes.md,citations.mdapi.mdopens with the whole pipeline as a short scriptAlso in this PR:
DOC_STANDARD.md: describes the new page layout.examples/DIIID-like_ideal_example/gpec.toml, which called itself the Δ′-matrix fixture. It runs"Forward", so it isn't; the Riccati example is.Facts checked against the code
"Riccati".gpec.h5path in the tables is checked against the writers or the schema registry.delta_prime.matrixdiagonal is the outer-region Δ′. The per-surfacedelta_primevector is a stub the code calls "not physically valid".integrator = "Forward"and no[Wall]. A wall or a Galerkin/matched result is an error. A Riccati result skips the response with a warning, so the failure only shows when a field is applied. The docs now say this plainly, and say that the Δ′ (tearing) and response cases therefore need separate decks.@docs/@autodocsentry is unchanged against the base, so nothing dropped out of the API reference.Please check
citations.mdentries for the error-field correction papers: Logan et al. 2026, Nucl. Fusion; Leuthold et al. 2026, J. Plasma Phys. They carry only the journal, year and DOI the old page printed. An agent had written titles from memory, and those were removed. Please add the real titles.Found but not changed (code, not docs)
src/Tearing/TearingProblem.jl:100–112falls back, with a warning, to the per-surfacedelta_primestub when no Δ′ matrix exists. So a Forward run can give SLAYER growth rates from a quantity the type docs call invalid.src/ForceFreeStates/Riccati/DeltaPrimeBVP.jl:504cites Glasser–Kolemen 2018 as PoP 25, 032501. It is 082502 (DOI 10.1063/1.5029477).plasma_response.plasma_responseon a Riccati result warns and returns empty operators rather than erroring early.Regression report
Documentation only: no file under
src/changes, so the harness does not apply. The docs build passed (Slurm job 137285), and so did pre-commit.🤖 Generated with Claude Code
https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF