Skip to content

Finalized Content Security Policy Fix#1567

Open
BrianRaymond800 wants to merge 18 commits into
OpenEnergyDashboard:developmentfrom
BrianRaymond800:pr-update
Open

Finalized Content Security Policy Fix#1567
BrianRaymond800 wants to merge 18 commits into
OpenEnergyDashboard:developmentfrom
BrianRaymond800:pr-update

Conversation

@BrianRaymond800

Copy link
Copy Markdown

Description

This PR contains work completed by @pogoco26 and @CamClendenon, which added a Content Security Policy to OED. Information about their work can be found in PR #1484. Since then, the code from that PR has been updated by @BrianRaymond800 to contain more comments, clarification, and general cleanup.

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

I am not aware of any limitations, besides those that were listed in the original PR.

@huss huss mentioned this pull request Feb 2, 2026
5 tasks

@huss huss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @BrianRaymond800 for updating this work.

  • There is a merge conflict in a file. I also think the branch may be out of date. Please carefully merge in development.
  • When I run OED and look in the web browser console, I see a number of security content msgs. These need to be figured out. I don't know if it relates to the commented out code that was removed as noted in a comment.
  • I've added some comments to consider.

Comment thread src/client/app/emotionCache.ts Outdated
Comment thread src/client/app/emotionCache.ts Outdated
Comment thread src/client/app/index.tsx Outdated
Comment thread src/client/app/index.tsx Outdated
Comment thread src/client/index.html
Comment thread src/server/app.js Outdated
Comment thread src/server/app.js Outdated
Comment thread webpack.config.js
Comment thread src/client/app/index.tsx Outdated
Comment thread src/client/index.html
multiple sites as an exceptions would be : img-src 'self' http://example.com https://site_example.net; becomes img-src 'self'
http://example.com https://site_example.net https://newException.com;
-->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of commented out lines were removed here from the original PR. I wanted to check if they had any value or were examples.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, those lines were an alternate implementation of the CSP that was rejected and replaced with the current one, but never fully removed. That is why I chose to remove it.

BrianRaymond800 pushed a commit to BrianRaymond800/OED that referenced this pull request Apr 5, 2026
…us with owners and upstream PR evidence

• Added Owner column identifying responsible team members for each finding
• Added upstream OpenEnergyDashboard PR references where fixes or work exist
• Corrected Issue OpenEnergyDashboard#6 status to In Progress based on open PR OpenEnergyDashboard#1567
• Clarified findings with no assigned owner or implementation work started
• Improved overall clarity and traceability of security remediation progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants