Replacement for PR1567 for context security policy#1656
Conversation
…d to any emotion based styles. Fixed majority of the CSP style tag problems but a few still remain. (Still in Progress)
formatting, comments, and readability.
and better clarification.
| multiple sites as an exceptions would be : img-src 'self' http://example.com https://site_example.net; becomes img-src 'self' | ||
| http://example.com https://site_example.net https://newException.com; | ||
| --> | ||
|
|
There was a problem hiding this comment.
This was comments from PR #1567 that may still need to be considers:
@huss said on 2 Feb. 26:
A number of commented out lines were removed here from the original PR. I wanted to check if they had any value or were examples.
and @BrianRaymond800 said on 10 Feb. 26:
From what I can tell, those lines were an alternate implementation of the CSP that was rejected and replaced with the current one, but never fully removed. That is why I chose to remove it.
I don't know if these lines are important or not, esp. given the console warnings.
huss
changed the title
|
On 2 Feb. 26 I left this on PR #1567:
To clarify, I now see these in the web browser console on initial load of OED. I also either get a blank page or a message saying OED cannot load. For Firefox: 
For Safari: 
For Chrome: 
The null issue and warnings need to be figured out. I don't know if any other changes should be made. |
3 participants
Description
For reasons I have not been able to figure out, I cannot push changes to PR #1567. Thus, I am creating a new PR to hopefully finalize it. I want to be clear that there is a lot of earlier work by @BrianRaymond800 in the previous PR and in the commit change. I only made very modest changes to clean it up.
As PR #1567 states:
So this also continues that work.