fix(command sender): treat Ignore Range Checks as hazardous and restore hazardous highlighting

openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-cmdsender/src/tools/CommandSender/CommandSender.vue

@@ -132,15 +132,17 @@
           <v-spacer />
         </v-toolbar>
         <v-card-text class="mt-6">
-          Warning: Command {{ hazardousCommand }} is Hazardous. Send?
-          <div class="mt-1">Description: {{ commandDescription }}</div>
+          Warning: {{ hazardousMessage }}. Send?
+          <div v-if="hazardousDialogDescription" class="mt-1">
+            Description: {{ hazardousDialogDescription }}
+          </div>
           <div
-            v-if="hazardousDescription"
+            v-if="hazardousDialogHazardousDescription"
             class="openc3-yellow font-weight-bold mt-2"
             data-test="hazardous-description"
           >
             <v-icon class="mr-1">mdi-alert</v-icon>
-            Hazardous: {{ hazardousDescription }}
+            Hazardous: {{ hazardousDialogHazardousDescription }}
           </div>
         </v-card-text>
         <v-card-actions class="px-2">
@@ -253,6 +255,9 @@
       status: '',
       history: '',
       hazardousCommand: '',
+      commandIsHazardous: false,
+      hazardousDialogDescription: '',
+      hazardousDialogHazardousDescription: '',
       displaySendHazardous: false,
       displayErrorDialog: false,
       displaySendRaw: false,
@@ -270,6 +275,27 @@
     }
   },
   computed: {
+    // Modes that make every command hazardous, e.g. 'range checks are ignored'
+    hazardousModes() {
+      const modes = []
+      if (this.ignoreRangeChecks) {
+        modes.push('range checks are ignored')
+      }
+      if (this.cmdRaw) {
+        modes.push('parameter conversions are disabled')
+      }
+      return modes.join(' and ')
+    },
+    hazardousMessage() {
+      const command = `Command ${this.hazardousCommand}`
+      if (!this.hazardousModes) {
+        return `${command} is Hazardous`
+      } else if (this.commandIsHazardous) {
+        return `${command} is Hazardous and ${this.hazardousModes}`
+      } else {
+        return `${command} is considered Hazardous because ${this.hazardousModes}`
+      }
+    },
     readOnlyUser: function () {
       const roles = OpenC3Auth.userroles() || []
       return roles.length > 0 && roles.every((role) => role === 'viewer')
@@ -555,17 +581,33 @@
       this.sendDisabled = true
       this.api.get_cmd_hazardous(targetName, commandName, paramList).then(
         (hazardous) => {
-          if (hazardous) {
-            // If it was sent from history it's all in targetName
+          // Ignoring range checks allows arbitrary values (e.g. manually
+          // entered states) and disabling conversions bypasses any that make
+          // a command safe so treat every command as hazardous
+          if (hazardous || this.hazardousModes) {
+            this.commandIsHazardous = hazardous
+            // If it was sent from history it's all in targetName and may
+            // differ from the selected command so look up its descriptions
             if (commandName === undefined) {
               this.hazardousCommand = targetName
                 .split(' ')
                 .slice(0, 2)
                 .join(' ')
+              this.api.get_cmd(...this.hazardousCommand.split(' ')).then(
+                (command) => {
+                  this.showHazardousDialog(command)
+                },
+                () => {
+                  this.showHazardousDialog(null)
+                },
+              )
             } else {
               this.hazardousCommand = `${targetName} ${commandName}`
+              this.showHazardousDialog({
+                description: this.commandDescription,
+                hazardous_description: this.hazardousDescription,
+              })
             }
-            this.displaySendHazardous = true
           } else {
             this.executeCmd(cmdInfo, false)
           }
@@ -576,6 +618,13 @@
       )
     },
 
+    showHazardousDialog(command) {
+      this.hazardousDialogDescription = command?.description || ''
+      this.hazardousDialogHazardousDescription =
+        command?.hazardous_description || ''
+      this.displaySendHazardous = true
+    },
+
     sendHazardousCmd() {
       this.displaySendHazardous = false
       this.executeCmd(

openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/CommandEditor.vue

@@ -18,7 +18,7 @@
         ref="targetPacketChooser"
         :initial-target-name="targetName"
         :initial-packet-name="commandName"
-        :disabled="sendDisabled"
+        :disabled="sendDisabled || commandLoading"
         :disable-button-text="readOnly ? 'Viewers cannot send commands' : null"
         :button-text="showCommandButton ? 'Send' : null"
         :show-queue-select="showQueueSelect"
@@ -176,6 +176,9 @@ export default {
       targetName: '',
       commandName: '',
       commandDescription: '',
+      // Keep Send disabled until the selected command's parameters and
+      // descriptions are loaded so we never send with stale values
+      commandLoading: false,
       ignoredParams: [],
       computedRows: [],
       reservedItemNames: [
@@ -250,6 +253,7 @@ export default {
       this.computedRows = []
       this.hazardousParameters = {}
       if (this.targetName && this.commandName) {
+        this.commandLoading = true
         this.api
           .get_target(this.targetName)
           .then(
@@ -263,6 +267,7 @@ export default {
           )
           .then(
             (command) => {
+              this.commandLoading = false
               if (command) {
                 // Identify length fields that are auto-managed by variable_bit_size arrays
                 // These should be shown but disabled - they will be set when the array is written
@@ -343,6 +348,7 @@ export default {
               }
             },
             (error) => {
+              this.commandLoading = false
               console.error('Error getting command parameters:', error)
               this.$emit('command-loaded', null)
             },

openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/CommandParameterEditor.vue

@@ -145,6 +145,10 @@ export default {
       if (!this.states) {
         return false
       }
+      // Manual entry requires ignoring range checks which is always hazardous
+      if (this.manuallyEntered) {
+        return true
+      }
       return (
         Object.entries(this.states)
           .find(([label, state]) => state.value === this.modelValue)
@@ -195,7 +199,8 @@ export default {
 .container {
   padding: 0px;
 }
-.hazardous :deep(.v-select__selection-text) {
+/* Extra .v-select specificity beats the themed override in _overrides.scss */
+.v-select.hazardous :deep(.v-select__selection-text) {
   color: rgb(255, 220, 0) !important;
 }
 </style>