Repository navigation
AI review fixes for #3949 - #4050
Merged
ryanmelt merged 1 commit intoOct 13, 2026
Merged
Conversation
- openc3-cosmos-cmd-tlm-api/app/models/streaming_thread.rb:165 - SonarQube S1186 flagged the empty base check_lag method; added a comment inside it explaining that it is empty on purpose because logged/historical streams are expected to be behind realtime - openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Graph.vue:2167 - SonarQube S7759: replaced new Date().getTime() with Date.now() in receivedNotice AI-Review-Bot: true AI-Review-Run: 38322971611
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/streaming-skip-ahead #4050 +/- ##
=============================================================
+ Coverage 80.10% 80.11% +0.01%
=============================================================
Files 901 901
Lines 68415 68414 -1
Branches 2652 2652
=============================================================
+ Hits 54804 54811 +7
+ Misses 12944 12936 -8
Partials 667 667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
ryanmelt
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the AI review of #3949 at 12000be. Merge this PR to apply them to
feat/streaming-skip-ahead; the full review summary is on #3949.What changed
fix(review): apply Claude review fixes (turn 1)