Repository navigation
AI review fixes for #4015 - #4030
Merged
jmthomas merged 2 commits intoOct 11, 2026
Merged
Conversation
- openc3/python/test/microservices/test_interface_microservice.py:890 - SonarQube python:S5906: replaced assertEqual(im.queued, True) with assertTrue(im.queued) - openc3/python/test/microservices/test_interface_microservice.py:912 - SonarQube python:S5906: replaced assertEqual(im.queued, False) with assertFalse(im.queued) AI-Review-Bot: true AI-Review-Run: 38000332622
- openc3/lib/openc3/microservices/interface_microservice.rb:609 - Nonzero telemetry shards retained a one-second queue interval; apply the configured interval to every telemetry target shard. - openc3/python/openc3/microservices/interface_microservice.py:696 - Fixed the equivalent shard interval bug and added Python and Ruby regression coverage. AI-Review-Bot: true AI-Review-Run: 38000332622
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## interface_queued_default #4030 +/- ##
============================================================
+ Coverage 80.14% 80.16% +0.02%
============================================================
Files 901 901
Lines 68378 68385 +7
Branches 2650 2650
============================================================
+ Hits 54800 54820 +20
+ Misses 12908 12895 -13
Partials 670 670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
jmthomas
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the AI review of #4015 at c2c42d3. Merge this PR to apply them to
interface_queued_default; the review summary is on #4015.