Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openc3/python/openc3/topics/command_decom_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def write_packet(cls, packet, scope):
"received_time": to_nsec_from_epoch(packet.received_time),
"target_name": packet.target_name,
"packet_name": packet.packet_name,
"stored": str(packet.stored),
"stored": str(packet.stored).lower(), # Match ruby behavior of "true"/"false"
"received_count": packet.received_count,
}
# Read all RAW values at once - optimized by accessor
Expand Down
2 changes: 1 addition & 1 deletion openc3/python/openc3/topics/command_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def write_packet(cls, packet, scope):
"target_name": packet.target_name,
"packet_name": packet.packet_name,
"received_count": packet.received_count,
"stored": str(packet.stored),
"stored": str(packet.stored).lower(), # Match ruby behavior of "true"/"false"
"buffer": bytes(packet.buffer_no_copy()),
}
if packet.extra:
Expand Down
2 changes: 1 addition & 1 deletion openc3/python/openc3/topics/telemetry_decom_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def write_packet(cls, packet, id=None, include_limits_states=True, scope=None):
msg_hash = {
"time": to_nsec_from_epoch(packet.packet_time),
"received_time": to_nsec_from_epoch(packet.received_time),
"stored": str(packet.stored),
"stored": str(packet.stored).lower(), # Match ruby behavior of "true"/"false"
"target_name": packet.target_name,
"packet_name": packet.packet_name,
"received_count": packet.received_count,
Expand Down
7 changes: 7 additions & 0 deletions openc3/python/test/topics/test_command_decom_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ def test_writes_to_correct_topic(self):
self.assertEqual(msg_hash["packet_name"], "CMD")
self.assertEqual(msg_hash["received_count"], 1)

def test_writes_stored_as_lowercase_like_ruby(self):
for stored, expected in [(True, "true"), (False, "false")]:
packet = self._make_packet()
packet.stored = stored
CommandDecomTopic.write_packet(packet, scope="DEFAULT")
self.assertEqual(self.captured["msg_hash"]["stored"], expected)

def test_logs_given_value_for_write_conversion_items(self):
packet = self._make_packet()
packet.given_values = {"VALUE": 5, "STATE": "TRUE"}
Expand Down
7 changes: 7 additions & 0 deletions openc3/python/test/topics/test_command_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ def test_writes_to_correct_topic(self):
self.assertEqual(msg_hash["received_count"], 1)
self.assertEqual(msg_hash["buffer"], b"\x01\x02\x03\x04")

def test_writes_stored_as_lowercase_like_ruby(self):
for stored, expected in [(True, "true"), (False, "false")]:
packet = self._make_packet()
packet.stored = stored
CommandTopic.write_packet(packet, scope="DEFAULT")
self.assertEqual(self.captured["msg_hash"]["stored"], expected)

def test_includes_extra_when_set(self):
extra = {"foo": "bar", "count": 42}
CommandTopic.write_packet(self._make_packet(extra=extra), scope="DEFAULT")
Expand Down
5 changes: 5 additions & 0 deletions openc3/python/test/topics/test_telemetry_decom_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ def test_writes_to_correct_decom_topic(self):
self.assertEqual(msg_hash["received_count"], 5)
self.assertIn("json_data", msg_hash)

def test_writes_stored_as_lowercase_like_ruby(self):
for stored, expected in [(True, "true"), (False, "false")]:
TelemetryDecomTopic.write_packet(self._make_packet(stored=stored), scope="DEFAULT")
self.assertEqual(self.captured["msg_hash"]["stored"], expected)

def test_includes_extra_when_set(self):
extra = {"foo": "bar", "count": 42}
TelemetryDecomTopic.write_packet(self._make_packet(extra=extra), scope="DEFAULT")
Expand Down
Loading