Repository navigation
fix(topics): write python command and decom stored flag as lowercase - #4005
Merged
Merged
Conversation
CommandTopic, CommandDecomTopic and TelemetryDecomTopic wrote stored as "True"/"False" while Ruby writes "true"/"false". Readers are case-insensitive, but the stream contents now match between implementations. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4005 +/- ##
==========================================
+ Coverage 80.06% 80.10% +0.04%
==========================================
Files 901 901
Lines 68370 68370
Branches 2699 2646 -53
==========================================
+ Hits 54738 54767 +29
+ Misses 12976 12936 -40
- Partials 656 667 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
ryanmelt
added
the
review-and-merge-ready
clayandgen
reviewed
Oct 14, 2026
clayandgen
left a comment
clayandgen
left a comment
Contributor
There was a problem hiding this comment.
openc3/python/openc3/topics/telemetry_topic.py:26: TelemetryTopic.write_packet still writes str(packet.stored)
mcosgriff
approved these changes
Oct 19, 2026
Contributor
This is fixed in #4000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandTopic,CommandDecomTopicandTelemetryDecomTopicwrotestoredasstr(packet.stored), so they produced"True"/"False". Ruby writes"true"/"false". Every reader compares case-insensitively, so nothing was broken, but the stream contents differed between the two implementations.interface_decom_common.pyand theTelemetryTopicfix in fix(microservices): validate pre-identified telemetry and keep stored data out of CVT #4000.Fixes the IF-CMD-007 deviation in
architecture/specs/interface-microservice.yaml. The decommutated telemetry topic had the same issue (IF-TLM-003), so it's fixed here too.Test plan
uv run pytest test/topics test/microservices(144 passed)ruff check/ruff format --checkclean🤖 Generated with Claude Code