fix(go): enforce battery thermal protection - #64
Conversation
| static constexpr int16_t OT_CHARGE_HOT_RESUME_C = 47; | ||
| static constexpr int16_t OT_SHIP_THRESHOLD_C = 60; | ||
| // --- Battery temperature thresholds --- | ||
| static constexpr int16_t CHARGE_MIN_TEMPERATURE_C = 0; |
There was a problem hiding this comment.
-
In Line 419-420: Why did "hysteresis" decrease from 3C to 2C for hot and cold recovery?
-
In Line 421: DISCHARGE_MIN_TEMPERATURE_C set to -10C? The AG Go's operating temperature on the manual is down to -20C, and while I don't have any hardware documentation at this point, I feel like the cell being used is a PKCELL LIPO785060 2500 mAh 3.7Vdc(nom) cell, which also supports discharge down to -20C, unless another component in the design sets this limit.
-
In Line 413: EDV_SHIP_THRESHOLD_V = 2.9f. This should be set to 3.0f as the discharge cutoff voltage for the PKCELL is 3.0 Vdc.
If a different cell is being used with different specifications, please accept my apologies as I didn't want to pull the cell off my brand-new AG Go, just yet... :)
Summary
Enforce the AirGradient Go battery operating-temperature policy to prevent charging or discharging outside safe limits and show the correct shutdown warning for hot and cold conditions.
Changes
overheatreason for compatibility.Validation
idf.py -C products/go buildpassed.git diff --checkand Markdown lint passed.