Discovery
Noticed there seems to only be a check to ensure that the battery is not permitted to charge, or the device be able to operate in high temperature conditions. There is not a check to determine if the battery is in a low temperature condition below 4C / 39F, in which case battery charge should be stopped. Also, if the temperature falls below -20C / -4F, the battery should not be allowed to discharge, and the device should turn off. (This is unless the device is using a Lithium-Ion battery that has a specific operational range outside that of a normal Lithium-based chemistry)
Expected behavior
A Li-Ion or Li-Poly battery should not be allowed to charge low temperature environments, and should not be discharged in low temperature environments.
Actual behavior
The battery is allowed to charge in low temperature environments, and discharge in extreme low temperature environments.
Steps to reproduce
Review of implemented code.
https://github.com/Open-Air-Foundation/oaf-fw-core/blob/96f7239e00cbd27ed8c7c98fbaf6bbee4ac9db17/products/go/main/go_power.cpp#L241
Proposed changes
Add block that checks for temperatures that in a low temperature condition, and either prevent charging, or in very low temperature conditions, prevent discharging of the battery.
Discovery
Noticed there seems to only be a check to ensure that the battery is not permitted to charge, or the device be able to operate in high temperature conditions. There is not a check to determine if the battery is in a low temperature condition below 4C / 39F, in which case battery charge should be stopped. Also, if the temperature falls below -20C / -4F, the battery should not be allowed to discharge, and the device should turn off. (This is unless the device is using a Lithium-Ion battery that has a specific operational range outside that of a normal Lithium-based chemistry)
Expected behavior
A Li-Ion or Li-Poly battery should not be allowed to charge low temperature environments, and should not be discharged in low temperature environments.
Actual behavior
The battery is allowed to charge in low temperature environments, and discharge in extreme low temperature environments.
Steps to reproduce
Review of implemented code.
https://github.com/Open-Air-Foundation/oaf-fw-core/blob/96f7239e00cbd27ed8c7c98fbaf6bbee4ac9db17/products/go/main/go_power.cpp#L241
Proposed changes
Add block that checks for temperatures that in a low temperature condition, and either prevent charging, or in very low temperature conditions, prevent discharging of the battery.