Skip to content

fix: resolve 4 bugs in Astrodex #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve 4 bugs in Astrodex #2125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/LeftSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function LeftSidebar() {

const handleSearch = useCallback(() => {
const id = parseInt(searchId, 10)
if (!isNaN(id) && id >= 1 && id <= 600) {
if (!Number.isNaN(id) && id >= 1 && id <= 600) {
searchAsteroidById(id)
}
}, [searchId, searchAsteroidById])
Expand Down
2 changes: 1 addition & 1 deletion src/components/RightSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function RightSidebar() {

const handleApply = () => {
const parsedDv = parseFloat(maxDv)
const maxDvVal = isNaN(parsedDv) ? 0.35 : parsedDv
const maxDvVal = Number.isNaN(parsedDv) ? 0.35 : parsedDv

const parsedBurns = parseInt(maxBurns, 10)
const maxBurnsVal = isNaN(parsedBurns) ? 1 : parsedBurns
Expand Down
2 changes: 1 addition & 1 deletion src/lib/store.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ export function AppProvider({
asteroidDataRef.current = data
if (focusedObjectId) {
const numId = parseInt(focusedObjectId.replace(/\D/g, ""), 10)
if (!isNaN(numId)) {
if (!Number.isNaN(numId)) {
const found = data.find((item) => item.id === numId)
if (found) {
setSelectedAsteroid(found)
Expand Down
Loading