fix: resolve 4 bugs in Astrodex - #2125
Conversation
|
Someone is attempting to deploy a commit to the Sp's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Tick the box to add this pull request to the merge queue (same as
|
|
Thanks — nice, small, low-risk fixes. I reviewed the diffs and this is almost ready to merge, but I found two small issues: One remaining use of the global isNaN in src/components/RightSidebar.tsx — please change:
The PR description mentions an empty-string validation change (trim().length vs trim() === '') that I don't see in the diffs. Could you either: |
Description
This PR fixes real bugs found in the codebase:
isNaNwithNumber.isNaN: the global version coerces its argument, soisNaN('1')returns false whileNumber.isNaNis strict.isNaNwithNumber.isNaN: the global version coerces its argument, soisNaN('1')returns false whileNumber.isNaNis strict.trim()to''misses whitespace-only input;.trim().length === 0is explicit.isNaNwithNumber.isNaN: the global version coerces its argument, soisNaN('1')returns false whileNumber.isNaNis strict.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #2124