truncate *relevant* modes instead of all modes - #45
Merged
Merged
Conversation
Fix energy-ranked spectral mode selection
colemanjs
added a commit
that referenced
this pull request
Jul 23, 2026
* Mpboundary tracking (#34) * melt pool boundary detection implementation * implemented newton iterations for boundary detection. * removed old is_boundary * updated readme with animation. * modified compute_morphology to handle new phases data format. * fixed visualization error flag. exits after printing defect status. * new visualization * precommit --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> Co-authored-by: John <colemanjs@ornl.gov> * Fixed 0 mod 90 rotation angle issues (#36) * fixed issue by enforcing lowerbound on vector components at construction time. * better implementation of signed clip + fix tol in core --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> * Mpfilter valueerror (#37) * fixed 0-indexing issue in self.t size and self.npoints discrepancy * changed to linspace to enforce same number of points. checked that dt was correct --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> * Test: fixed test suite, added it to the CI, and identified/corrected floating point error in core * pre-commit fix * Fixed: XML error in vti * Doc: improved formatting and documentation for the synthetic api example to guide users * Fixup for time scale in synthetic melt pool * Fixup for time scale in synthetic melt pool * tolerance check in rv * mpfilter fix for proper timeseries generation * fixed spectral component determination with rmse construction * precommit lol * changes to autoselection of melt pool filter * Fix CI, API, and CLI for melt pool filter * truncate *relevant* modes instead of all modes (#45) * truncate *relevant* modes instead of all modes * fixed only one test * Fix energy-ranked spectral mode selection --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> Co-authored-by: John <colemanjs@ornl.gov> * fixup for melt pool filter args * fix active learning melt pool filter resolution --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> Co-authored-by: John <colemanjs@ornl.gov>
colemanjs
added a commit
that referenced
this pull request
Jul 27, 2026
* Mpboundary tracking (#34) * melt pool boundary detection implementation * implemented newton iterations for boundary detection. * removed old is_boundary * updated readme with animation. * modified compute_morphology to handle new phases data format. * fixed visualization error flag. exits after printing defect status. * new visualization * precommit --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> Co-authored-by: John <colemanjs@ornl.gov> * Fixed 0 mod 90 rotation angle issues (#36) * fixed issue by enforcing lowerbound on vector components at construction time. * better implementation of signed clip + fix tol in core --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> * Mpfilter valueerror (#37) * fixed 0-indexing issue in self.t size and self.npoints discrepancy * changed to linspace to enforce same number of points. checked that dt was correct --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> * Test: fixed test suite, added it to the CI, and identified/corrected floating point error in core * pre-commit fix * Fixed: XML error in vti * Doc: improved formatting and documentation for the synthetic api example to guide users * Fixup for time scale in synthetic melt pool * Fixup for time scale in synthetic melt pool * tolerance check in rv * mpfilter fix for proper timeseries generation * fixed spectral component determination with rmse construction * precommit lol * changes to autoselection of melt pool filter * Fix CI, API, and CLI for melt pool filter * truncate *relevant* modes instead of all modes (#45) * truncate *relevant* modes instead of all modes * fixed only one test * Fix energy-ranked spectral mode selection --------- Co-authored-by: Vamsi Subraveti <vis@ornl.gov> Co-authored-by: John <colemanjs@ornl.gov> * fixup for melt pool filter args * add and use output-scaler log - add overhang 10 to raptor call * factor utilities into seperate modules * add create defect model for two inputs --------- Co-authored-by: Vamsi Subraveti <119705737+subravvr@users.noreply.github.com> Co-authored-by: Vamsi Subraveti <vis@ornl.gov> Co-authored-by: John <colemanjs@ornl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yeehaw mode truncation the right way