[jtojnar]

Description of changes

adwaita-qt tries valiantly to ensure a visual consistency but unfortunately, it often falls into an uncanny valley instead. Let’s make it opt-in again for more vanilla default experience.

Related: https://pagure.io/fedora-workstation/issue/351

cc @bobby285271

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[bobby285271]

I personally am actually quite happy with the current status of Adwaita-qt, but I am okay to change the defaults if users do complain about that. Or do we wait for Fedora to patch their QGnomePlatform not to use Adwaita-qt since Fedora does not seem to have plans to drop QGnomePlatform? #245166 (comment)

[jtojnar]

Another issue is that some Qt 6 apps do not display anything – GNOME Shell only shows a completely transparent window.

Noticed with #232527 in Wayland session (tried with #232527 as well), nothing in the console. It works fine with qt.enable = false. On X11 it is only transparent sometimes but it still has broken titlebar:

Weirdly, at least one Qt 6 app (qalculate-qt) works (with complains):

qt.core.plugin.loader: In /nix/store/lmd3dhjhgh1r0dl26xp8vqaqdz783hxs-qgnomeplatform-0.8.4/lib/qt-5.15.9/plugins/platformthemes/libqgnomeplatformtheme.so:
  Plugin uses incompatible Qt library (5.15.0) [release]
qt.dbus.integration: Could not connect "org.freedesktop.IBus" to globalEngineChanged(QString)
qt.core.plugin.loader: In /nix/store/vmahwgvx9v7p0acn8fxlxqhdss9k8iv9-adwaita-qt-1.4.1/lib/qt-5.15.9/plugins/styles/adwaita.so:
  Plugin uses incompatible Qt library (5.15.0) [release]

[jtojnar]

The upstream is now officially not maintained so let’s merge this.