Skip to content

adwaita-qt: 1.4.1 → 1.4.2 - #232813

Merged
wegank merged 1 commit into
NixOS:masterfrom
bobby285271:upd/adwaita-qt
May 22, 2023
Merged

adwaita-qt: 1.4.1 → 1.4.2#232813
wegank merged 1 commit into
NixOS:masterfrom
bobby285271:upd/adwaita-qt

Conversation

@bobby285271

@bobby285271 bobby285271 commented May 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
Description of changes

FedoraQt/adwaita-qt@1.4.1...1.4.2

Things done
  • Checked postPatch is still needed for Qt5
  • hydrus (Qt6) starts on GNOME and theme applies
  • fcitx5-configtool (Qt5) starts on GNOME and theme applies

unreviewed qgnomeplatform bump bobby285271@4b5501b - #351 is not done yet

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg
ofborg Bot requested review from amaxine, dasj19, hedning and jtojnar May 19, 2023 11:27
@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 19, 2023
jtojnar
jtojnar approved these changes May 20, 2023
View reviewed changes

@jtojnar jtojnar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay. Still want to not enable it by default, though #210077

@wegank
wegank merged commit 46ad986 into NixOS:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes
@hedning hedning Awaiting requested review from hedning
@amaxine amaxine Awaiting requested review from amaxine
@dasj19 dasj19 Awaiting requested review from dasj19

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobby285271 @jtojnar @wegank