Skip to content

fix: show logs for tasks killed by runtime without finished_at #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
npow wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: show logs for tasks killed by runtime without finished_at #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/pages/Task/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useTranslation } from 'react-i18next';
import styled from 'styled-components';
import { SetQuery, StringParam, useQueryParams } from 'use-query-params';
import { apiHttp } from '@/constants';
import { Artifact, AsyncStatus, Run as IRun, Task as ITask } from '@/types';
import { Artifact, AsyncStatus, Run as IRun, Task as ITask, TaskStatus } from '@/types';
import AnchoredView from '@pages/Task/components/AnchoredView';
import ArtifactActionBar from '@pages/Task/components/ArtifactActionBar';
import ArtifactTable from '@pages/Task/components/ArtifactTable';
Expand Down Expand Up @@ -74,6 +74,11 @@ const emptyFn = () => {
/*intentional*/
};

// Tasks killed by the runtime (e.g. Titus OOM/eviction) never write attempt-done
// metadata, so finished_at stays null. Treat these terminal statuses as done so
// logs are fetched regardless.
const TERMINAL_TASK_STATUSES: TaskStatus[] = ['completed', 'failed', 'unknown'];

//
// Component
//
Expand Down Expand Up @@ -163,7 +168,7 @@ const Task: React.FC<TaskViewProps> = ({
}
}, [task, addDataToStore]);

const isCurrentTaskFinished = !!(task && task.finished_at);
const isCurrentTaskFinished = !!(task && (task.finished_at || TERMINAL_TASK_STATUSES.includes(task.status)));
const isLatestAttempt = attemptId === (tasks?.length || 1) - 1;

const handleToggleCollapse = (type: 'expand' | 'collapse') =>
Expand Down
Loading