fix: show logs for tasks killed by runtime without finished_at - #207
Open
npow wants to merge 1 commit into
Open
Conversation
Tasks killed by Titus (OOM, eviction, etc.) never write the attempt-done metadata record, leaving finished_at null. The UI gated log fetching on finished_at being set, so logs were silently never fetched even when they existed in S3. Fix: treat any terminal task status (completed, failed, unknown) as "finished enough" to fetch logs, regardless of finished_at. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Metaflow task is killed by the runtime (e.g. Titus OOM or eviction), the in-container agent is also killed before it can write the
attempt-donemetadata record. This leavesfinished_at = nullon the task object returned by the backend.The UI gates log fetching on
isCurrentTaskFinished = !!(task && task.finished_at). Withfinished_atnull,isCurrentTaskFinishedisfalse,pausedistruein bothuseLogDatacalls, and logs are never fetched — even though they exist in S3.The logs are there. The UI just never asks for them.
Fix
Treat any terminal task status (
completed,failed,unknown) as "finished enough" to fetch logs, regardless of whetherfinished_atis populated:The
preloadpath for live streaming is unchanged — it still only activates forstatus === 'running'.Test plan
failed,finished_at=null): logs now appear in the UIcompleted,finished_atset): logs still appear (no regression)preloadpathunknownstatus: logs now appear if they exist in S3🤖 Generated with Claude Code