Skip to content

review all notebooks are functioning correctly#350

Merged
RDaxini merged 5 commits into
developmentfrom
notebook_check
Jul 10, 2026
Merged

review all notebooks are functioning correctly#350
RDaxini merged 5 commits into
developmentfrom
notebook_check

Conversation

@RDaxini

@RDaxini RDaxini commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes

Reran all notebooks to ensure accurate outputs and no errors.
Replaced several API calls local file usage for tests. This can be switched back to making an API call if the user wishes in real applications.
Note on temperature scenario notebook: previously silently printed "No function results found" because the extract/plot helper filtered scene_temp.results.keys() looking for a "function" tuple key, but results is actually keyed by module-name strings. Now fixed.

Issue ticket number and link

Fixes #342

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@RDaxini RDaxini changed the base branch from main to development June 30, 2026 18:36
@RDaxini RDaxini added this to the v0.7.2 milestone Jun 30, 2026
@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (51172fd) to head (b8a8db2).
⚠️ Report is 505 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #350      +/-   ##
===============================================
+ Coverage        71.66%   74.72%   +3.06%     
===============================================
  Files               40       41       +1     
  Lines             4524     4823     +299     
===============================================
+ Hits              3242     3604     +362     
+ Misses            1282     1219      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RDaxini RDaxini requested a review from martin-springer July 1, 2026 18:56
@RDaxini RDaxini linked an issue Jul 1, 2026 that may be closed by this pull request
@RDaxini RDaxini removed the request for review from martin-springer July 1, 2026 19:09
@RDaxini RDaxini merged commit d93aca2 into development Jul 10, 2026
25 of 26 checks passed
@RDaxini RDaxini deleted the notebook_check branch July 10, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JOSS] Out‑of‑date Jupyter notebooks – a few are broken

3 participants