[JOSS] Out‑of‑date Jupyter notebooks – a few are broken

[FlorianK13]

I am generally impressed by the amount of information in the notebooks. They are well documented and help understanding the typical workflows. However some (and only some) of these notebooks do not run, for example tutorials/04_scenario/01_scenario_temperature.ipynb fails when trying scene_temp.run() with Attribute Error:

'NoneType' object has no attribute 'keys'

As a user, it can be very frustrating if notebooks referenced in the docs page fail with errors that are not easy to understand.

I see some possible solutions here:

• Maybe you could define a sub section of "critical docs notebooks" that describe the core functionality and keep those up to date?
• You could also think about integrating these notebooks into your testing? I have never done that, but based on this blog post it seems doable.

I am open to discuss this further - in the end you are the maintainer and devs and you know much more about this repo :)

This issue is part of a joss review, see openjournals/joss-reviews#10617

[RDaxini]

Thank you for checking the notebooks, finding these issues, and proposing solutions. The notebooks are a core part of pvdeg and we want them to be functioning correctly.
I ran through all of the notebooks to verify their functionality. All are now working, including the temperature notebooks you highlighted as well as a couple of others that were experiencing issues. The changes are in #350. This issue will be closed once that PR has been merged.
This should mitigate the need to document errors/failing notebooks, since the goal is to have them all working.
Thanks again for catching this.

[RDaxini]

Closing as resolved by #350