Skip to content

ci: enable codecov for Python test coverage #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 9 commits into from
Jul 17, 2026
Merged

ci: enable codecov for Python test coverage #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
003e569
ci: enable codecov for Python test coverage
ramakrishnap-nv Jul 14, 2026
3a9e2f3
ci: trigger CI
ramakrishnap-nv Jul 15, 2026
a5edaec
ci: pass CODECOV_TOKEN via secrets inherit for PR builds
ramakrishnap-nv Jul 15, 2026
c06c38f
ci: pass CODECOV_TOKEN via script-env-secret-4
ramakrishnap-nv Jul 15, 2026
044c38d
Revert "ci: pass CODECOV_TOKEN via script-env-secret-4"
ramakrishnap-nv Jul 15, 2026
67d3d62
ci: pass CODECOV_TOKEN explicitly in pr.yaml
ramakrishnap-nv Jul 16, 2026
8a511a9
ci: revert to secrets: inherit until shared-workflows#593 merges
ramakrishnap-nv Jul 16, 2026
381fc2f
Revert "ci: revert to secrets: inherit until shared-workflows#593 mer…
ramakrishnap-nv Jul 16, 2026
6536236
ci: trigger CI
ramakrishnap-nv Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ jobs:
- '!.github/workflows/trigger-breaking-change-alert.yaml'
- '!.gitignore'
- '!.pre-commit-config.yaml'
- '!codecov.yml'
- '!AGENTS.md'
- '!CHANGELOG.md'
- '!CONTRIBUTING.md'
Expand Down Expand Up @@ -155,6 +156,7 @@ jobs:
- '!.github/workflows/trigger-breaking-change-alert.yaml'
- '!.gitignore'
- '!.pre-commit-config.yaml'
- '!codecov.yml'
- '!AGENTS.md'
- '!CONTRIBUTING.md'
- '!LICENSE'
Expand Down Expand Up @@ -224,6 +226,7 @@ jobs:
- '!.github/workflows/trigger-breaking-change-alert.yaml'
- '!.gitignore'
- '!.pre-commit-config.yaml'
- '!codecov.yml'
- '!AGENTS.md'
- '!CONTRIBUTING.md'
- '!LICENSE'
Expand Down Expand Up @@ -290,6 +293,7 @@ jobs:
- '!.github/workflows/trigger-breaking-change-alert.yaml'
- '!.gitignore'
- '!.pre-commit-config.yaml'
- '!codecov.yml'
- '!AGENTS.md'
- '!CONTRIBUTING.md'
- '!LICENSE'
Expand Down Expand Up @@ -410,16 +414,11 @@ jobs:
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@main
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_conda
with:
run_codecov: false
build_type: pull-request
script: ci/test_python.sh
secrets:
script-env-secret-1-key: CUOPT_S3_URI
script-env-secret-1-value: ${{ secrets.CUOPT_S3_URI }}
script-env-secret-2-key: CUOPT_AWS_ACCESS_KEY_ID
script-env-secret-2-value: ${{ secrets.CUOPT_AWS_ACCESS_KEY_ID }}
script-env-secret-3-key: CUOPT_AWS_SECRET_ACCESS_KEY
script-env-secret-3-value: ${{ secrets.CUOPT_AWS_SECRET_ACCESS_KEY }}
script-env-secret-1-key: CODECOV_TOKEN
script-env-secret-1-value: ${{ secrets.CODECOV_TOKEN }}
Comment on lines 419 to +421

@coderabbitai coderabbitai Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Ensure CODECOV_TOKEN reaches the reusable workflow’s upload step.

This explicit script-env-secret-1-* mapping may only expose the token to ci/test_python.sh; the shared workflow’s Codecov step previously resolved ${{ secrets.CODECOV_TOKEN }} separately, which can leave the upload token empty. Use secrets: inherit or a supported declared secret input, then verify a private-repository run completes the upload.

Proposed fix 
-    secrets:
-      script-env-secret-1-key: CODECOV_TOKEN
-      script-env-secret-1-value: ${{ secrets.CODECOV_TOKEN }}
+    secrets: inherit
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/pr.yaml around lines 419 - 421, Update the reusable
workflow invocation in pr.yaml so CODECOV_TOKEN is passed through to the shared
workflow’s Codecov upload step, using secrets inheritance or the workflow’s
supported declared secret input instead of relying only on
script-env-secret-1-key/script-env-secret-1-value. Preserve the existing test
script environment mapping as needed, and verify a private-repository run
completes the Codecov upload.

docs-build:
needs: [conda-python-build, changed-files]
permissions:
Expand Down
12 changes: 12 additions & 0 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Configuration File for CodeCov
comment: false
coverage:
status:
project: off
patch:
default:
target: auto
threshold: 5%
informational: true
github_checks:
annotations: true
2 changes: 2 additions & 0 deletions python/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ include = cuopt/cuopt/*
cuopt_server/cuopt_server/*
omit = cuopt_server/cuopt_server/tests/*
cuopt/cuopt/tests/*
disable_warnings = module-not-measured
no-data-collected