ci: enable codecov for Python test coverage - #1575
Merged
Merged
Conversation
Removes the explicit `run_codecov: false` override in pr.yaml and test.yaml, restoring the shared-workflow default (true). Adds codecov.yml at repo root with patch checks set to informational so coverage never blocks a PR. Adds disable_warnings to .coveragerc to suppress spurious coverage.py noise. Excludes codecov.yml from changed-files triggers so a config-only edit does not re-run CI. Note: requires CODECOV_TOKEN to be set as a repo or org secret. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
ramakrishnap-nv
added
non-breaking
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesCodecov configuration, Python coverage warning handling, and related pull-request workflow behavior are updated. The conda Python test job now passes Codecov CI integration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI Test Summary✅ All 31 test job(s) passed. |
Collaborator
Author
|
/ok to test 003e569 |
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Switch conda-python-tests in pr.yaml to secrets: inherit so CODECOV_TOKEN reaches the shared-workflow codecov step. S3/AWS secrets are not needed for PR builds (nightly_report_helper skips S3 when RAPIDS_BUILD_TYPE!=nightly). Re-add run_codecov: false to test.yaml conda-python-tests since S3 explicit secrets are required there for nightly report aggregation, leaving no slot for CODECOV_TOKEN until rapidsai/shared-workflows#<TBD> lands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Use the same key/value pattern as S3/AWS secrets to pass CODECOV_TOKEN to the conda-python-tests shared workflow. Requires rapidsai/shared-workflows#593. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
This reverts commit c06c38f. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
S3/AWS secrets are not needed for PR builds so slot 1 is free. Use script-env-secret-1 for CODECOV_TOKEN instead of secrets: inherit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
KyleFromNVIDIA
approved these changes
Jul 16, 2026
The explicit script-env-secret-1 approach injects CODECOV_TOKEN via GITHUB_ENV but the current shared workflow overrides it with an empty secrets.CODECOV_TOKEN in the codecov step. Revert to inherit for now. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
…ges" This reverts commit 8a511a9. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Around line 419-421: Update the reusable workflow invocation in pr.yaml so
CODECOV_TOKEN is passed through to the shared workflow’s Codecov upload step,
using secrets inheritance or the workflow’s supported declared secret input
instead of relying only on script-env-secret-1-key/script-env-secret-1-value.
Preserve the existing test script environment mapping as needed, and verify a
private-repository run completes the Codecov upload.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0f740f6b-9059-46b5-9d86-6b6384712bcb
📒 Files selected for processing (1)
.github/workflows/pr.yaml
Comment on lines
419
to
+421
| secrets: | ||
| script-env-secret-1-key: CUOPT_S3_URI | ||
| script-env-secret-1-value: ${{ secrets.CUOPT_S3_URI }} | ||
| script-env-secret-2-key: CUOPT_AWS_ACCESS_KEY_ID | ||
| script-env-secret-2-value: ${{ secrets.CUOPT_AWS_ACCESS_KEY_ID }} | ||
| script-env-secret-3-key: CUOPT_AWS_SECRET_ACCESS_KEY | ||
| script-env-secret-3-value: ${{ secrets.CUOPT_AWS_SECRET_ACCESS_KEY }} | ||
| script-env-secret-1-key: CODECOV_TOKEN | ||
| script-env-secret-1-value: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Ensure CODECOV_TOKEN reaches the reusable workflow’s upload step.
This explicit script-env-secret-1-* mapping may only expose the token to ci/test_python.sh; the shared workflow’s Codecov step previously resolved ${{ secrets.CODECOV_TOKEN }} separately, which can leave the upload token empty. Use secrets: inherit or a supported declared secret input, then verify a private-repository run completes the upload.
Proposed fix
- secrets:
- script-env-secret-1-key: CODECOV_TOKEN
- script-env-secret-1-value: ${{ secrets.CODECOV_TOKEN }}
+ secrets: inherit🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/pr.yaml around lines 419 - 421, Update the reusable
workflow invocation in pr.yaml so CODECOV_TOKEN is passed through to the shared
workflow’s Codecov upload step, using secrets inheritance or the workflow’s
supported declared secret input instead of relying only on
script-env-secret-1-key/script-env-secret-1-value. Preserve the existing test
script environment mapping as needed, and verify a private-repository run
completes the Codecov upload.
Iroy30
approved these changes
Jul 16, 2026
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the explicit
run_codecov: falseoverride, addscodecov.yml(patch checks informational, never blocks), suppresses spurious coverage.py warnings, and excludescodecov.ymlfrom changed-files triggers.Requires
CODECOV_TOKENto be set as a repo/org secret.