ensure nightly builds always produce new packages, expand 'changed-files' lists - #8448
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe workflows add a shared ChangesBuild datetime propagation
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/build.yaml (1)
99-111: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winFix
python-build.needs.needsis not a job ID. Set the value to[build-details, cpp-build]soneeds.build-details.outputs.build-datetimeis available.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build.yaml around lines 99 - 111, Update the python-build job’s needs list to reference the actual build-details and cpp-build job IDs, replacing needs so needs.build-details.outputs.build-datetime is available to the workflow.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr.yaml:
- Around line 105-106: Replace the misspelled .gihtub/workflows/labeler.yml
exclusion with .github/workflows/labeler.yml in the changed-files groups for
build_docs, test_cpp, test_notebooks, test_python_conda, and test_python_wheels.
Apply this at .github/workflows/pr.yaml lines 105-106, 135-136, 176-177,
214-215, and 257-258.
---
Outside diff comments:
In @.github/workflows/build.yaml:
- Around line 99-111: Update the python-build job’s needs list to reference the
actual build-details and cpp-build job IDs, replacing needs so
needs.build-details.outputs.build-datetime is available to the workflow.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 77a7a849-e69f-4883-a8fa-76e43d0f09c9
📒 Files selected for processing (7)
.github/workflows/build.yaml.github/workflows/pr.yamlci/build_cpp.shci/build_python.shci/build_wheel.shconda/recipes/cuml/recipe.yamlconda/recipes/libcuml/recipe.yaml
|
/merge |
|
Haven't yet been able to get passing CI here. The most recent failure in Python tests (cond and wheels) looks like this:
Looks like #8458 skipped that test, pulling in latest |
|
CI is still stuck here because of the GitHub outage (https://www.githubstatus.com/incidents/qcvjkzcs7j74). Will try again later. |
|
Wow looks like GitHub allowed a job that was queued over 6 hours ago to eventually get scheduled when they recovered from the outage... I thought for SURE they'd shed old jobs. Anyway yay, this is merged 😁 |
Contributes to rapidsai/build-planning#218
For wheels:
And for conda:
Other changes:
changed-fileslists to avoid triggering test jobs in PR CI when only.github/workflows/{build,test}.yamlare changedNotes for Reviewers
How I tested this
See rapidsai/cugraph-gnn#508