Skip to content

ensure nightly builds always produce new packages, expand 'changed-files' lists - #8448

Merged
rapids-bot[bot] merged 10 commits into
NVIDIA:mainfrom
jameslamb:nightly-versions
Aug 7, 2026
Merged

ensure nightly builds always produce new packages, expand 'changed-files' lists#8448
rapids-bot[bot] merged 10 commits into
NVIDIA:mainfrom
jameslamb:nightly-versions

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Contributes to rapidsai/build-planning#218

For wheels:

# before
26.10.0a55 

# after
26.10.0a55.post260803200854

And for conda:

# before
26.10.0a55[build=cuda12_260803_9da146ef]

# after
26.10.0a55[build=cuda12_260803200854_9da146ef]

Other changes:

  • updates changed-files lists to avoid triggering test jobs in PR CI when only .github/workflows/{build,test}.yaml are changed

Notes for Reviewers

How I tested this

See rapidsai/cugraph-gnn#508

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 4, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb changed the title ensure nightly builds always produce new packages WIP: ensure nightly builds always produce new packages Aug 4, 2026
@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: ensure nightly builds always produce new packages ensure nightly builds always produce new packages Aug 5, 2026
@jameslamb
jameslamb marked this pull request as ready for review August 5, 2026 01:56
@jameslamb
jameslamb requested review from a team as code owners August 5, 2026 01:56
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5fd7a3a3-3ebc-40b8-b026-4a43e6f3b539

📥 Commits

Reviewing files that changed from the base of the PR and between 5925f40 and 01389d0.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/pr.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Build and Release Improvements

    • Added consistent date-and-time metadata to C++, Python, and wheel builds.
    • Package build identifiers now include precise build timestamps, improving release traceability.
    • Coordinated shared build information across dependent automated workflows.
  • Maintenance

    • Updated build scripts and package recipes to use the standardized timestamp format.
    • Refreshed copyright information in relevant build files.
    • Improved pull request workflow handling for documentation and test-only changes.

Walkthrough

The workflows add a shared build-details job and propagate build-datetime to build jobs. Shell scripts and conda recipes replace date-only metadata with datetime-based values.

Changes

Build datetime propagation

Layer / File(s) Summary
Shared build metadata wiring
.github/workflows/build.yaml
Adds the reusable build-details job and passes its build-datetime output to C++, Python, and wheel builds.
Pull request workflow integration
.github/workflows/pr.yaml
Adds build metadata dependencies and outputs to pull request builds. Updates changed-file exclusions for build, labeler, and test workflows.
Datetime-based package metadata
ci/build_*.sh, conda/recipes/*/recipe.yaml
Uses RAPIDS_DATETIME_STRING for build scripts and conda package build strings. Wheel versions receive a datetime-based .post suffix.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: unique nightly packages and expanded changed-files lists.
Description check ✅ Passed The description directly explains the nightly versioning changes and changed-files updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/build.yaml (1)

99-111: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Fix python-build.needs. needs is not a job ID. Set the value to [build-details, cpp-build] so needs.build-details.outputs.build-datetime is available.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/build.yaml around lines 99 - 111, Update the python-build
job’s needs list to reference the actual build-details and cpp-build job IDs,
replacing needs so needs.build-details.outputs.build-datetime is available to
the workflow.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pr.yaml:
- Around line 105-106: Replace the misspelled .gihtub/workflows/labeler.yml
exclusion with .github/workflows/labeler.yml in the changed-files groups for
build_docs, test_cpp, test_notebooks, test_python_conda, and test_python_wheels.
Apply this at .github/workflows/pr.yaml lines 105-106, 135-136, 176-177,
214-215, and 257-258.

---

Outside diff comments:
In @.github/workflows/build.yaml:
- Around line 99-111: Update the python-build job’s needs list to reference the
actual build-details and cpp-build job IDs, replacing needs so
needs.build-details.outputs.build-datetime is available to the workflow.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 77a7a849-e69f-4883-a8fa-76e43d0f09c9

📥 Commits

Reviewing files that changed from the base of the PR and between 3d02990 and ba57889.

📒 Files selected for processing (7)
  • .github/workflows/build.yaml
  • .github/workflows/pr.yaml
  • ci/build_cpp.sh
  • ci/build_python.sh
  • ci/build_wheel.sh
  • conda/recipes/cuml/recipe.yaml
  • conda/recipes/libcuml/recipe.yaml

Comment thread .github/workflows/pr.yaml Outdated
@jameslamb jameslamb changed the title ensure nightly builds always produce new packages ensure nightly builds always produce new packages, expand 'changed-files' lists Aug 5, 2026
Comment thread .github/workflows/build.yaml Outdated
@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@jameslamb

Copy link
Copy Markdown
Member Author

Haven't yet been able to get passing CI here. The most recent failure in Python tests (cond and wheels) looks like this:

FAILED test_sklearn_compatibility.py::test_sklearn_compatible_estimator[RandomForestRegressor()-check_regressor_data_not_an_array] - [XPASS(strict)] Predictions from repeated fits on equivalent inputs can differ beyond the check's tolerance

(build link)

Looks like #8458 skipped that test, pulling in latest main and trying another run.

@jameslamb

Copy link
Copy Markdown
Member Author

CI is still stuck here because of the GitHub outage (https://www.githubstatus.com/incidents/qcvjkzcs7j74). Will try again later.

@rapids-bot
rapids-bot Bot merged commit 7e9970f into NVIDIA:main Aug 7, 2026
106 checks passed
@jameslamb
jameslamb deleted the nightly-versions branch August 7, 2026 00:41
@jameslamb

Copy link
Copy Markdown
Member Author

Wow looks like GitHub allowed a job that was queued over 6 hours ago to eventually get scheduled when they recovered from the outage... I thought for SURE they'd shed old jobs.

Anyway yay, this is merged 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants