ensure nightly builds always produce new packages - #863
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| # Matches 6 digits starting with "2", which should be YYMMDD | ||
| date_re = r"(?:^|_)(2\d{5})_" | ||
| # Matches 12 digits starting with "2", which should be YYMMDDhhmmss | ||
| date_re = r"(?:^|_)(2\d{11})_" |
There was a problem hiding this comment.
Proposing doing this in the same PR to also test that all RAPIDS packages have appropriately-updated version components.
That'll mean this is the last PR in the series to merge, I think that's totally fine.
There was a problem hiding this comment.
the last PR in the series to merge
Looks like just cuml is left!
Date string not found for libcuml in the build string 'cuda13_260806_fbe8dbe5'.
Date string not found for cuml in the build string 'cuda13_cp311_abi3_260806_fbe8dbe5'.
Error: The following packages are missing dates in their build strings:
- cuml
- libcuml
NVIDIA/cuml#8448 just merged a few minutes ago
As soon as its main build finishes (https://github.com/rapidsai/cuml/actions/runs/31135338229), CI should pass on a re-run here 😁
There was a problem hiding this comment.
This date string hard-codes the number 2 at the beginning. Do you have a plan to deal with the Y3K problem? 😁
There was a problem hiding this comment.
throw it on the backlog 😛
|
/ok to test |
| # Matches 6 digits starting with "2", which should be YYMMDD | ||
| date_re = r"(?:^|_)(2\d{5})_" | ||
| # Matches 12 digits starting with "2", which should be YYMMDDhhmmss | ||
| date_re = r"(?:^|_)(2\d{11})_" |
There was a problem hiding this comment.
This date string hard-codes the number 2 at the beginning. Do you have a plan to deal with the Y3K problem? 😁
|
/merge |
Contributes to rapidsai/build-planning#218
And for conda:
Notes for Reviewers
How I tested this
See rapidsai/cugraph-gnn#508