Skip to content

test(conformance): ignore slow-TERM delete until the supervisor half of #5025 lands #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elezar merged 1 commit into from
Nov 6, 2026
+6 −1
Merged

test(conformance): ignore slow-TERM delete until the supervisor half of #5025 lands #5338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tasks/scripts/check-conformance-program.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ trap 'rm -rf "${work}"' EXIT

cargo run --quiet --locked --manifest-path "${manifest}" --bin openshell-conformance -- list \
| awk '{print $1}' | sort > "${work}/program"
cargo nextest list --locked --color never --manifest-path "${manifest}" --message-format oneline \
# --run-ignored all: the program lists ignored tests too, so nextest must as well.
cargo nextest list --locked --color never --run-ignored all --manifest-path "${manifest}" --message-format oneline \
| awk '{print $2}' | sort > "${work}/nextest"

if [[ ! -s "${work}/nextest" ]]; then
Expand Down
4 changes: 4 additions & 0 deletions tests/suites/conformance/src/lifecycle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ const DELETE_DEADLINE: Duration = Duration::from_secs(10);
/// Many workloads do not exit immediately on TERM, for example while they run
/// cleanup handlers. Deleting such a running sandbox should still complete
/// promptly, rather than waiting out the runtime's termination grace period.
//
// Unignore this when the supervisor half of #5025 lands: on Podman the
// supervisor container still waits out its stop timeout.
#[testkit::test]
#[ignore = "https://github.com/NVIDIA/OpenShell/issues/5025"]
async fn delete_is_prompt_when_workload_is_slow_to_handle_term(
cx: &mut Context,
) -> testkit::Result {
Expand Down
Loading