Repository navigation
test(conformance): ignore slow-TERM delete until the supervisor half of #5025 lands - #5338
Merged
Merged
Conversation
#5025 lands The test fails on Podman because the supervisor container waits out its stop timeout. Also list ignored tests in check-conformance-program.sh so the program list still matches nextest's. Signed-off-by: Evan Lezar <elezar@nvidia.com>
matthewgrossman
approved these changes
Nov 6, 2026
elezar
added
area:build
elezar
enabled auto-merge
November 6, 2026 16:04
|
Label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignores the conformance test
lifecycle::delete_is_prompt_when_workload_is_slow_to_handle_term, which fails in the podman-e2e lane on main. The supervisor half of #5025 is still open: theopenshell-supervisor-<id>container waits out its 15s stop timeout before delete completes.Related Issue
Part of #5025
Changes
#[ignore = "https://github.com/NVIDIA/OpenShell/issues/5025"]with a comment to unignore it when the supervisor half lands.tasks/scripts/check-conformance-program.sh: pass--run-ignored alltocargo nextest list. Nextest omits ignored tests by default, butopenshell-conformance listincludes them, so the check would otherwise fail for any ignored test.Testing
cargo clippy --manifest-path tests/suites/conformance/Cargo.toml --workspace --all-targets -- -D warningspassescargo fmt --checkfor the conformance manifest passestasks/scripts/check-conformance-program.shpasses (16 tests match)openshell-conformance listshows the test as ignored with the issue linkChecklist