Skip to content

refactor(e2e): consolidate Rust test support - #4537

Closed
elezar wants to merge 1 commit into
codex/4119-conformance-storiesfrom
codex/4119-shared-rust-support
Closed

elezar wants to merge 1 commit into
codex/4119-conformance-storiesfrom
codex/4119-shared-rust-support

Conversation

@elezar

@elezar elezar commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Consolidate the CLI runner and common Rust E2E utilities under e2e/support/rust. Conformance, driver, and feature suites share the same tooling while suite directory relocation remains a separate change.

Stacked on #4536 (codex/4119-conformance-stories). Followed by #4538 and #4464.

Related Issue

Closes #4119. Part of #3954.

Changes

  • Move the runner and process executor out of the product workspace and remove crates/openshell-conformance.
  • Extract binary resolution, output parsing, and port utilities from the existing Rust E2E harness; retain harness re-exports for consumers.
  • Update suite dependencies, lockfiles, local and branch source checks, and documentation.
  • Keep driver and feature suites at tests/suites for this unit.

Testing

  • mise run pre-commit passed for this signed-off commit.
  • Shared support tests (24) and pure policy assertions (3) passed.
  • Podman test targets compiled at their existing location; the feature workspace passed locked all-target compilation.
  • Shared support, conformance, and the existing Rust E2E harness passed Clippy.

Live gateway tests were not rerun during this split.

The combined stack at 7e72adc6c passed nix develop --command mise run --jobs 1 ci on 2026-10-14. This covers the configured repository lint, compile/type checks, and unit suites; live gateway/tmachine execution was not repeated during this split.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Relevant suite and testing guidance updated.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

This pull request has had no activity for 14 days and is now marked stale.

@github-actions github-actions Bot added the state:stale Inactive item at risk of automatic closure. label Oct 29, 2026
@elezar

elezar commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

crates/openshell-conformance is deleted by #5137; shared support is testkit plus tests/support.

Closing as superseded. The conformance suite now lives at tests/suites/conformance on testkit (#4774), and #5137 migrates the features and drivers suites and deletes crates/openshell-conformance, so this stack's layout and runner changes no longer apply.

The one idea worth keeping, cleanup for resources testkit does not track (with a deliberate-panic test), is being discussed in #5137 (comment).

The contributor-guidance points from the old README are listed in #4120.

@elezar elezar closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:stale Inactive item at risk of automatic closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant