Skip to content

test(conformance): organize stories into area modules - #4536

Closed
elezar wants to merge 1 commit into
codex/4119-conformance-suitefrom
codex/4119-conformance-stories
Closed

elezar wants to merge 1 commit into
codex/4119-conformance-suitefrom
codex/4119-conformance-stories

Conversation

@elezar

@elezar elezar commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Organize the conformance tests into file-transfer, lifecycle, policy-advisor, and smoke areas with individual story modules. This isolates the authoring layout change from both scenario ownership and runner extraction.

Stacked on #4120 (codex/4119-conformance-suite). Followed by #4537, #4538, and #4464.

Related Issue

Part of #4119 and #3954.

Changes

  • Split the existing scenario files into story modules and area-local helpers with a Cargo integration-test entry point per area.
  • Separate lifecycle persistence and stopped-sandbox deletion into independent tests, giving nine live conformance tests.
  • Keep pure policy-draft assertions in a dedicated module and update their Cargo/nextest selection.
  • Document story authoring and suite execution; retain the runner in its existing crate.

Testing

  • mise run pre-commit passed for this signed-off commit.
  • The tree matches the validated local story-module preview: runner tests, pure policy assertions, all-target compilation, and conformance Clippy passed.

Live gateway tests were not rerun during this split.

The combined stack at 7e72adc6c passed nix develop --command mise run --jobs 1 ci on 2026-10-14. This covers the configured repository lint, compile/type checks, and unit suites; live gateway/tmachine execution was not repeated during this split.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Relevant suite and testing guidance updated.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

This pull request has had no activity for 14 days and is now marked stale.

@github-actions github-actions Bot added the state:stale Inactive item at risk of automatic closure. label Oct 29, 2026
@elezar

elezar commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Area files are already split on main, including persistent_workspace and separate stopped-sandbox tests.

Closing as superseded. The conformance suite now lives at tests/suites/conformance on testkit (#4774), and #5137 migrates the features and drivers suites and deletes crates/openshell-conformance, so this stack's layout and runner changes no longer apply.

The one idea worth keeping, cleanup for resources testkit does not track (with a deliberate-panic test), is being discussed in #5137 (comment).

The contributor-guidance points from the old README are listed in #4120.

@elezar elezar closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:stale Inactive item at risk of automatic closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant