Skip to content

docs: fix WebXR build setup commands - #852

Merged
yanziz-nvidia merged 1 commit into
mainfrom
codex/webxr-doc-paths-20260730
Jul 31, 2026
Merged

docs: fix WebXR build setup commands#852
yanziz-nvidia merged 1 commit into
mainfrom
codex/webxr-doc-paths-20260730

Conversation

@arussell-nvidia

@arussell-nvidia arussell-nvidia commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update WebXR SDK setup commands to use the repository-root scripts
  • use the package.json dependency through the standard npm install flow

Validation

  • git diff --check
  • confirmed both referenced scripts exist and package.json points to the downloaded local SDK package

Summary by CodeRabbit

  • Documentation
    • Updated WebXR build instructions to use local setup scripts for configuring the CloudXR.js environment and downloading the SDK.
    • Simplified dependency installation instructions to use npm install with the locally downloaded package.

Signed-off-by: Andrew Russell <arussell@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 30ce45c1-22f2-48c1-a68a-31a04ef7339e

📥 Commits

Reviewing files that changed from the base of the PR and between 1ac164c and 4dfa35c.

📒 Files selected for processing (1)
  • docs/source/getting_started/build_from_source/webxr.rst

📝 Walkthrough

Walkthrough

The WebXR build documentation now instructs developers to run the CloudXR environment setup and SDK download scripts, placing the SDK in deps/cloudxr/. Dependency installation now uses npm install from the WebXR client directory instead of referencing a versioned SDK tarball.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the documentation update to the WebXR build setup commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/webxr-doc-paths-20260730

Comment @coderabbitai help to get the list of available commands.

Comment thread docs/source/getting_started/build_from_source/webxr.rst
@yanziz-nvidia
yanziz-nvidia merged commit a5142b3 into main Jul 31, 2026
44 checks passed
@yanziz-nvidia
yanziz-nvidia deleted the codex/webxr-doc-paths-20260730 branch July 31, 2026 20:10
yanziz-nvidia added a commit that referenced this pull request Jul 31, 2026
Signed-off-by: Andrew Russell <arussell@nvidia.com>
Co-authored-by: Yanzi Zhu <yanziz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants