Repository navigation
Conversation
d7219fd to
2600591
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
2600591 to
b2a73ec
Compare
b2a73ec to
f3cf727
Compare
f3cf727 to
f241e8e
Compare
f241e8e to
e255248
Compare
e255248 to
c907cfe
Compare
11b0439 to
45d3cda
Compare
8d51c8c to
c7c2f0f
Compare
[Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryAdds a bounded YAML loader and server-owned
The previous-review ancestry checks did not pass, so the full PR diff was reviewed.
|
tanushriya910
left a comment
There was a problem hiding this comment.
Overall looks good. Added one comment on improving error messages so end users can diagnose failures. Since users calling create_proxy_application directly already see these same exceptions, it makes more sense to ensure the errors never include raw inputs at the source than to redact them at the CLI layer.
|
Thank you @tanushriya910 for the reviews 🙌🏻 I'll address your comment before meeging. |
a85214f to
98754ad
Compare
98754ad to
489a591
Compare
73fe79d to
2a546cf
Compare
Let operators validate, inspect and serve the existing typed composition without Python glue. Keep the CLI inside the server so independent packaging does not depend on the library executable. Derive manifest validation and editor schema from the Python configuration, require fixed Rails bindings, bound YAML parsing, reject indirection and sanitize diagnostics. Inspect actual directional profiles without exposing unfinished variant selection. Reuse the existing lifespan and provide separate proxy/Rails example files. Manifest and CLI regressions include real-core partial catalogue rollback. Core cancellation and incomplete-cleanup prerequisites remain separate; the known queue cleanup retry regression still fails. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Adapt the preserved local-upstream harness to the server-owned module CLI and existing application assembly. Check native and LiteLLM Chat and Responses in buffered and streaming modes, block input before dispatch, and withhold blocked output. Verify guarded and passthrough disconnects close upstream sockets, later requests still work, and launcher subprocesses terminate cleanly. Fixtures are synthetic and use no live provider credentials. These smoke tests do not establish resolution of the separate interrupted-cleanup prerequisites. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Keep the manifest and Rails example under the server's ownership so the planned standalone-package move can carry them together. Update guide commands and socket-test paths without changing runtime or configuration behavior. Validation: 71 manifest and localhost launcher tests passed; changed-file pre-commit passed. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Replace smoke-test markers with a local email-pattern input/output rule and use explicit 200/50 streaming windows. Explain provider-delta units, buffering latency, detection limits, and the inability to retract previously released prefixes. Exercise the shipped configuration over real sockets, including split addresses, partial and full blocked windows, and downstream disconnects. Leave temporary smoke tooling untouched. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Copy the complete bundled example into a deployment-owned directory and use the local proxy.yaml path for launcher commands. Keep the module entry point supported by this branch; the standalone executable belongs to the later packaging change. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Create an isolated Windows process group and send CTRL_BREAK_EVENT, which Uvicorn handles for graceful shutdown, instead of forcefully terminating the process. Keep the bounded shutdown wait, forced reap on failure and shutdown-complete assertion on every platform; scope the POSIX signal exit-code assertion to POSIX. Validation: all five real-socket launcher tests passed on Python 3.10 and 3.13; pre-commit passed. Windows execution requires CI confirmation. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Allow 30 seconds for server draining and the existing Rails and HTTP cleanup budgets. Reap the child before reporting a timeout and include its complete output. Require shutdown completion without cleanup-failure or cleanup-timeout warnings on every platform. Validation: all five real-socket launcher tests passed on Python 3.10 and 3.13; pre-commit passed. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Send an explicit TCP write EOF and drain the peer's remaining response before closing the downstream socket. Keep the live ASGI disconnect, upstream closure and continued-serving assertions while avoiding a reset that can interrupt Windows Proactor socket cleanup before server detachment. Preserve normal cleanup budgets for healthy closers and shorten them only for intentionally hanging test doubles. Validation: 98 launcher and streaming HTTP tests passed on Python 3.10 and 3.13; pre-commit passed. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
2a546cf to
88d9f70
Compare
Description
Add bounded YAML loading and server-owned
validate,inspect,schemaandservecommands. Include a local Rails example and offline socket tests; reuse the typed configuration and existing lifespan.Stack: #2466 → #2467 → #2468. Package separation follows separately; API-docs prototype excluded.
Summary by CodeRabbit
New Features
Documentation
Tests