[Pouyanpi]

Description

Select provider instances, operations, dialects and Rails configs through typed Python configuration, reusing the existing application assembly. No runtime policy generation.

Stack: #2466 → #2467 → #2468. Package separation follows separately; API-docs prototype excluded.

PR	Base
#2467: typed composition	#2466
#2468: YAML/launcher	#2467

Summary by CodeRabbit

• New Features

  • Added an experimental Python proxy application with declarative configuration for providers, operations, dialects, and Rails configurations.
  • Supports fixed or dynamically selected Rails configurations, custom integrations, local routes, request limits, and timeouts.
  • Configuration and routing are validated before the application starts.

• Documentation

  • Added guidance covering setup, supported providers, routing, validation, authentication boundaries, and lifecycle behavior.

• Bug Fixes

  • Improved configuration validation to reject invalid, conflicting, incomplete, or unsupported settings.

[codecov]

Codecov Report

❌ Patch coverage is 98.42520% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...moguardrails/server/experimental/_configuration.py	97.80%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA-NeMo/Guardrails/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 1ffafb77-bd72-4314-a973-2aab975aaf3b

📥 Commits

Reviewing files that changed from the base of the PR and between 6afe8d3 and bf9dc0a.

📒 Files selected for processing: 6

• nemoguardrails/server/experimental/_application.py
• nemoguardrails/server/experimental/_configuration.py
• nemoguardrails/server/experimental/application.md
• nemoguardrails/server/experimental/application.py
• nemoguardrails/server/experimental/rails/config.py
• tests/server/experimental/test_application_configuration.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The proxy application now supports validated declarative configuration alongside explicit provider integrations. Provider endpoints and fixed or dynamic Rails configuration selection are resolved during application construction. Tests cover configuration validation, routing, and guarded and passthrough request handling.

Changes: Proxy Application Configuration

Layer / File(s)	Summary
Configuration contracts and provider resolution nemoguardrails/server/experimental/_configuration.py, nemoguardrails/server/experimental/rails/config.py, nemoguardrails/server/experimental/application.md, tests/server/experimental/test_application_configuration.py	Adds immutable provider and application configuration models, validates Rails configuration entries, and resolves supported provider bindings and Rails selections. Tests cover validation, endpoint bindings, and schema behavior.
Application construction and settings nemoguardrails/server/experimental/_application.py, nemoguardrails/server/experimental/application.py, nemoguardrails/server/experimental/application.md, tests/server/experimental/test_application_configuration.py	Adds factory overloads for declarative configuration and explicit integrations, applies configuration values or defaults, and exports the public application API. Tests cover construction, settings, routing, and pre-resource validation.
Request-time Rails selection and proxy behavior nemoguardrails/server/experimental/application.md, tests/server/experimental/test_application_configuration.py	Documents fixed and dynamic Rails selection. Tests cover resolver context and failures, blocked and passthrough traffic, and buffered and streaming responses.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant ProxyApplication
  participant ConfigResolver
  participant RailsCatalogue
  participant UpstreamTransport
  Client->>ProxyApplication: Send guarded request
  ProxyApplication->>ConfigResolver: Resolve Rails configuration with request context
  ConfigResolver-->>ProxyApplication: Return selected Rails configuration
  ProxyApplication->>RailsCatalogue: Apply selected Rails configuration
  ProxyApplication->>UpstreamTransport: Forward permitted request
  UpstreamTransport-->>ProxyApplication: Return buffered or streaming response
  ProxyApplication-->>Client: Return proxy response

Loading

Merge Risk: ⚪ Minimal · up to bf9dc

No actionable issue remains from this review; the change is mergeable after normal checks.

Pre-merge checks: 4 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 16.98% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 53 functions across 5 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Results For Major Changes		The PR contains a major feature change: it adds typed proxy configuration, expands the public application factory, and adds 589 lines of configuration tests. The authored PR description contains only …	Add a Testing section to the PR description. Document the focused test run, the complete experimental-server test result, pre-commit status, and any known pre-existing failure with its scope.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: composing proxy applications from typed configuration.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 16.98% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 53 functions across 5 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Full details: Test Results For Major Changes

Explanation

The PR contains a major feature change: it adds typed proxy configuration, expands the public application factory, and adds 589 lines of configuration tests. The authored PR description contains only the feature description and stack information. It does not document test commands or test results.

Resolution

Add a Testing section to the PR description. Document the focused test run, the complete experimental-server test result, pre-commit status, and any known pre-existing failure with its scope.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds typed Python configuration for composing proxy applications from reviewed provider bindings and a shared Rails catalogue.

• Python settings choose the proxy’s provider operations and Rails rules.
• Each provider can use fixed Rails rules or choose them per request.

No actionable issues were found. Tests were inspected, not run. The previous-review comparison failed the ancestry/base guards, so this review covered the full PR diff. No previous review threads were supplied.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ProxyConfig] --> B[Validate declaration]
    B --> C[Select reviewed provider bindings]
    B --> D{Rails selection}
    D -->|Fixed| E[Use declared config ID]
    D -->|Dynamic| F[Call trusted resolver]
    C --> G[Existing application assembly]
    E --> G
    F --> G
    G --> H[Validate catalogue paths and routes]
    H --> I[Lifespan starts HTTP client and Rails checkers]

Loading

_{Reviews (7) · Last reviewed commit: "test(server): align declarative Response..." · Reviewed by Greptile}

[tanushriya910]

changes look good to me, one non blocking question: the docs are clear that operations isn't a route allowlist, but once this is driven from YAML a reader may only see the config. wondering if an option to reject unguarded routes per instance is worth a follow-up, or we want to maintain the current behavior as part of the full passthrough design?

[m-misiura]

changes look good to me, one non blocking question: the docs are clear that operations isn't a route allowlist, but once this is driven from YAML a reader may only see the config. wondering if an option to reject unguarded routes per instance is worth a follow-up, or we want to maintain the current behavior as part of the full passthrough design?

agreeing with @tanushriya910, no reason not to LGTM

[Pouyanpi]

Thanks @tanushriya910 and @m-misiura 🚀 I agree, an explicit per-instance option to reject unguarded routes should be a separate follow-up. this PR preserves the existing passthrough behavior (which I don't like it)

[m-misiura]

Thanks @tanushriya910 and @m-misiura 🚀 I agree, an explicit per-instance option to reject unguarded routes should be a separate follow-up. this PR preserves the existing passthrough behavior (which I don't like it)

Ack, seperate follow-up sounds good. LGTM