Fix CTB collision geometry in URDF - #21
Merged
Merged
Conversation
ndunkelb-nasa
approved these changes
Aug 28, 2026
ndunkelb-nasa
left a comment
ndunkelb-nasa
left a comment
Contributor
There was a problem hiding this comment.
Wow, can't believe those ended up in there like that!
Comment on lines
-36
to
-38
| <material name="ctb_grey"> | ||
| <color rgba="1.0 1.0 1.0 1.0"/> | ||
| </material> |
Contributor
There was a problem hiding this comment.
For what it is worth, we have a ton of these floating around this repository. I think we honestly need to do a quick roundup of material issues that affect the whole clr_ws stack. I have a branch where I made stuff look better, but didn't address any of the underlying issues. Should probably do that though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found an oopsie while debugging some of the URDF to MJCF conversion issues.
Basically the visual and collision geometries had stale transforms and scales.