Skip to content

Simplify General Mockup Manager - #19

Merged
ndunkelb-nasa merged 8 commits into
mainfrom
ndunkelb/simplify-general-mockup-manager
Aug 18, 2026
Merged

Simplify General Mockup Manager#19
ndunkelb-nasa merged 8 commits into
mainfrom
ndunkelb/simplify-general-mockup-manager

Conversation

@ndunkelb-nasa

Copy link
Copy Markdown
Contributor

Found this general mockup manager that existed, which makes things a lot nicer. However, I found that the implementation was a bit annoying in that it required your parameter file to look like below. I think before, I wasn't aware of how to get the info for the individual topics without having an extra topic_names parameter that could then be referenced. This new change basically gets rid of the need to have the topic_names parameter and instead just uses the top level values after topics as the topic names.

This was written a while ago, so there might be some other simplifications that could be made now...

`hatch_4060_localization_manager:
  ros__parameters:
    topic_names: 
    - hatch_localization_x
    - hatch_localization_y
    topics:
      hatch_localization_x:
        joint_name: "hatch_localization_x_joint"
        min_position: -0.02
        max_position: 0.02
        initial_position: 0.0
      hatch_localization_y:
        joint_name: "hatch_localization_y_joint"
        min_position: -0.02
        max_position: 0.02
        initial_position: 0.0`

@mtobia-nasa

mtobia-nasa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Should this script live somewhere other than hatch_4040/scripts?

Seems like it would fit better in mockups_launch_common/scripts

@ndunkelb-nasa

Copy link
Copy Markdown
Contributor Author

Should this script live somewhere other than hatch_4040/scripts?

Seems like it would fit better in mockups_launch_common/scripts

Definitely true! Moved.

Comment thread hatch_4040/CMakeLists.txt Outdated
)

# set default parameter of prefix to empty
self.declare_parameter("prefix", "")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this with automatically_declare_parameters_from_overrides=True, I think you can also get errors if it's here and we try overriding this? Not that it really matters here...

ndunkelb-nasa and others added 3 commits August 18, 2026 09:15
Co-authored-by: Erik Holum <erik.holum@nasa.gov>
…:NASA-JSC-Robotics/surface_robotics_mockups_description into ndunkelb/simplify-general-mockup-manager

@eholum-nasa eholum-nasa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I blame myself for the format breakage)

Once it's fixed LGTM!

@ndunkelb-nasa
ndunkelb-nasa merged commit 433c4ff into main Aug 18, 2026
1 check passed
@ndunkelb-nasa
ndunkelb-nasa deleted the ndunkelb/simplify-general-mockup-manager branch August 18, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants