Simplify General Mockup Manager - #19
Merged
Merged
Conversation
ndunkelb-nasa
requested review from
crainen-nasa,
mtobia-nasa and
scastro-nasa
August 17, 2026 19:03
Contributor
|
Should this script live somewhere other than Seems like it would fit better in |
Contributor
Author
Definitely true! Moved. |
scastro-nasa
approved these changes
Aug 17, 2026
eholum-nasa
reviewed
Aug 17, 2026
| ) | ||
|
|
||
| # set default parameter of prefix to empty | ||
| self.declare_parameter("prefix", "") |
Member
There was a problem hiding this comment.
I don't think you need this with automatically_declare_parameters_from_overrides=True, I think you can also get errors if it's here and we try overriding this? Not that it really matters here...
Co-authored-by: Erik Holum <erik.holum@nasa.gov>
…:NASA-JSC-Robotics/surface_robotics_mockups_description into ndunkelb/simplify-general-mockup-manager
eholum-nasa
approved these changes
Aug 18, 2026
eholum-nasa
left a comment
Member
There was a problem hiding this comment.
(I blame myself for the format breakage)
Once it's fixed LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this general mockup manager that existed, which makes things a lot nicer. However, I found that the implementation was a bit annoying in that it required your parameter file to look like below. I think before, I wasn't aware of how to get the info for the individual topics without having an extra topic_names parameter that could then be referenced. This new change basically gets rid of the need to have the
topic_namesparameter and instead just uses the top level values aftertopicsas the topic names.This was written a while ago, so there might be some other simplifications that could be made now...