MapObj: Implement Motorcycle - #1325
Open
german77 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
status:waiting for review
Co-authored-by: GRAnimated <devin@nhscan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally this requested class is almost fully done. With the exception of
Motorcycle::movementhttps://decomp.me/scratch/B2j7L everything else is implemented. Requires open-ead/sead#276 for init to match.The motorcycle is a complicated actor. First of all it can do quite a bit of stuff like having a "puppet" driving it. It can jump, crash and is affected by water.
Huge thanks to GRA for all the help provided. It made this PR arrive much earlier than expected.
This change is
Report for 1.0 (4a87ded - 25beda3)
📈 Matched code: 15.71% (+0.22%, +28128 bytes)
✅ 90 new matches
MapObj/MotorcycleMotorcycle::receiveMsg(al::SensorMsg const*, al::HitSensor*, al::HitSensor*)MapObj/MotorcycleupdateRunningVelocity(Motorcycle*, float)MapObj/MotorcycleupdateOrientation(Motorcycle*, float)MapObj/MotorcycleMotorcycle::exeRideRunJump()MapObj/MotorcycletryParking(Motorcycle*, IUsePlayerPuppet*, ParkingParams*, MotorcyclePose*)MapObj/MotorcycleMotorcycle::exeRideWaitJump()MapObj/MotorcycleMotorcycle::exeRideRun()MapObj/MotorcycleMotorcycle::exeRideRunStart()MapObj/MotorcycleMotorcycle::exeRideRunCollide()MapObj/MotorcycleupdateSteerAngleAndAccel(Motorcycle*, IUsePlayerPuppet*, AccelerationState*, float*)MapObj/MotorcycleupdateSeRumble(SeRumbleState*, Motorcycle*, IUsePlayerPuppet*, float, bool)MapObj/MotorcycleMotorcycle::exeRideRunLand()MapObj/MotorcycleupdateBoundPhysics(Motorcycle*, IUsePlayerPuppet*, float*, SeRumbleState*, bool)MapObj/MotorcycleMotorcycle::exeRideRunWheelie()MapObj/MotorcyclecalcInputStick(sead::Vector2<float>*, Motorcycle*, IUsePlayerPuppet*)MapObj/MotorcycleMotorcycle::exeRideRunFall()MapObj/MotorcyclestartGetOff(Motorcycle*, IUsePlayerPuppet**, int*, MotorcyclePlayerAnimator*, al::CameraTargetBase*, al::TransCameraSubTarget*)MapObj/MotorcycleupdateAirOrientation(Motorcycle*)MapObj/MotorcycletryLand(Motorcycle*)MapObj/MotorcycletryBound(Motorcycle*)MapObj/MotorcycleMotorcycle::exeRideWait()MapObj/MotorcycleMotorcycle::exeWait()MapObj/MotorcycleMotorcycle::exeRideWaitLand()MapObj/MotorcycleMotorcycle::updateCollider()MapObj/MotorcycletryHandleWallCollision(Motorcycle*)MapObj/MotorcycleTryWheelieOrFall(Motorcycle*)MapObj/MotorcyclesyncPuppetPose(IUsePlayerPuppet*, Motorcycle*, sead::Quat<float> const&, sead::Vector3<float> const&)MapObj/MotorcycleMotorcycle::exeJump()MapObj/MotorcycletryHandleHighSpeedWallCollision(Motorcycle*, sead::Vector3<float> const&)MapObj/MotorcycleMotorcycle::exeCreep()...and 60 more new matches
📈 2 improvements in unmatched items
MapObj/MotorcycleMotorcycle::movement()MapObj/MotorcycleMotorcycle::init(al::ActorInitInfo const&)