all: Enforce weak / global functions - #1249
Draft
german77 wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
the
status:waiting for review
german77
force-pushed
the
dontBeWeak
branch
4 times, most recently
from
June 29, 2026 15:58
bcc582b to
65c86f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1231. Fully eliminates all weak / global mismatches from smo. Unlike the previous PR I call it an aggressive approach since it will break some matches and duplicate code. The lost matches will be recovered once the object is used.
depends on:
open-ead/NintendoSDK-NEX#6
open-ead/sead#269
open-ead/eui#6
This change is
Report for 1.0 (0de3c75 - fbc7d4e)
📉 Matched code: 15.35% (-0.01%, -1108 bytes)
✅ 6 new matches
Unknown/SePlayersead::StringBuilderBase<char16_t>::rstripUnprintableAsciiChars()Unknown/SePlayersead::StringBuilderBase<char16_t>::replaceChar(char16_t, char16_t)sead/gfx/nvn/seadDebugFontMgrJis1Nvnsead::DebugFontMgrJis1Nvn::~DebugFontMgrJis1Nvn()sead/gfx/nvn/seadDebugFontMgrJis1Nvnsead::DebugFontMgrJis1Nvn::~DebugFontMgrJis1Nvn()sead/gfx/nvn/seadDebugFontMgrNvnsead::DebugFontMgrNvn::~DebugFontMgrNvn()sead/gfx/nvn/seadDebugFontMgrNvnsead::DebugFontMgrNvn::~DebugFontMgrNvn()🥀 42 broken matches
Player/HackCapHackCapThrowParam::HackCapThrowParam(al::LiveActor*)sead/framework/nx/seadGameFrameworkNxsead::LogicalFrameBuffer::checkDerivedRuntimeTypeInfo(sead::RuntimeTypeInfo::Interface const*) constsead/framework/nx/seadGameFrameworkNxsead::LogicalFrameBuffer::getRuntimeTypeInfo() constsead/gfx/seadDrawLockContextsead::MathCalcCommon<int>::gcd(int, int)sead/gfx/seadDrawLockContextsead::MathCalcCommon<unsigned int>::gcd(unsigned int, unsigned int)sead/gfx/seadDrawLockContextsead::MathCalcCommon<long>::gcd(long, long)sead/gfx/seadDrawLockContextsead::MathCalcCommon<unsigned long>::gcd(unsigned long, unsigned long)Library/Sequence/Sequenceal::IUseSceneCreator::~IUseSceneCreator()Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<char const*>::isValidPtr() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<sead::Vector3<float> >::isValidPtr() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<sead::Color4f>::isValidPtr() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<bool>::isValidPtr() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<unsigned char>::isValidPtr() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<float>::isValidPtr() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<sead::Vector2<float> >::isValidPtr() constLibrary/Sequence/Sequenceal::Sequence::isDisposable() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<char const*>::clearPtr()Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_YamlString::getClassId() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_YamlString::setPtr_YamlString(char const**)Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<sead::Vector3<float> >::clearPtr()Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_V3f::getClassId() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_V3f::setPtr_V3f(sead::Vector3<float>*)Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<sead::Color4f>::clearPtr()Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_YamlColor::getClassId() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_YamlColor::setPtr_YamlColor(sead::Color4f*)Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<bool>::clearPtr()Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_bool::getClassId() constLibrary/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_bool::setPtr_bool(bool*)Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParamBase<unsigned char>::clearPtr()Library/Shadow/ShadowMaskCtrlalYamlMacroUtil::YamlParam_u8::getClassId() const...and 12 more broken matches
📉 1 regression in an unmatched item
Npc/SmallBirdStateFlyAwaySmallBirdStateFlyAway::exeFlyAway()