feat!: add flow-zigzag layout rule - #28
Draft
emaarco wants to merge 1 commit into
Draft
Conversation
emaarco
force-pushed
the
emaarco/zigzag-flow-rule
branch
from
August 22, 2026 09:44
1364307 to
da674ac
Compare
emaarco
changed the title
Reports a sequence flow that reverses on itself and keeps bending instead of reaching its target directly. Decides purely on DI coordinates, scoped per BPMNPlane: a monotone flow (never doubling back on either axis) is always fine, a reversing flow gets a small wrap-bend budget (maxWrapBends, default 3). The monotonicity check judges each segment by its dominant axis, so a near-orthogonal rung's minor-axis drift is not mistaken for a reversal. Ships error in `all` and non-blocking warn in both recommended layers. Closes #32
emaarco
force-pushed
the
emaarco/zigzag-flow-rule
branch
from
August 22, 2026 10:02
da674ac to
200a872
Compare
emaarco
changed the title
emaarco
changed the title
emaarco
marked this pull request as draft
August 22, 2026 10:34
Member
Author
|
on purpose in draft status. currently a WIP - with some edge cases that i still want to discover |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
flow-zigzaglayout rule: reports a sequence flow that reverses on itself and keeps bending instead of reaching its target directly.Decides purely on DI coordinates, scoped per
BPMNPlane:maxWrapBends, default 3); beyond it, report. Self-loops are skipped.The monotonicity check judges each segment by its dominant axis, so a near-orthogonal rung's minor-axis drift is not mistaken for a reversal (avoids a false positive on a slightly imperfect staircase).
Ships
errorinplugin:@miragon/rules/alland non-blockingwarnin both recommended layers →feat!(can raise a consumer'sallbuild to red).Note:
flow-orthogonalwas split out of the original combined change into its own draft PR (#31), so this branch now contains onlyflow-zigzag.Closes #32