feat!: add flow-orthogonal layout rule - #33
Merged
Conversation
Reports a sequence flow drawn on a slant — a flow with a segment running diagonally instead of horizontally or vertically. Decides purely on DI coordinates, scoped per BPMNPlane: a segment counts as slanted when its shorter-axis span exceeds a small fraction (~10 degrees) of its longer one, so a few pixels of drift on a long segment stays orthogonal. Overlaps on purpose with flow-target-alignment (which points at the misaligned shapes behind a diagonal); the two suggest different fixes. Ships error in `all` and non-blocking warn in both recommended layers. Closes #31
emaarco
force-pushed
the
emaarco/orthogonal-flow-rule
branch
from
August 22, 2026 09:53
099276e to
007bafe
Compare
emaarco
marked this pull request as ready for review
August 22, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
flow-orthogonallayout rule: reports a sequence flow drawn on a slant — a flow with a segment running diagonally instead of horizontally or vertically.Decides purely on DI coordinates, scoped per
BPMNPlane: a segment counts as slanted when its shorter-axis span exceeds a small fraction (~10°) of its longer one, so a few pixels of drift on a long segment stays orthogonal while a genuine diagonal does not.Overlaps on purpose with
flow-target-alignment(which points at the misaligned shapes behind a diagonal); the two suggest different fixes.Ships
errorinplugin:@miragon/rules/alland non-blockingwarnin both recommended layers →feat!.Draft on purpose. This is the smaller / less-settled of the two rules originally landed together; it is split out of #28 so the clearer
flow-zigzagrule can proceed independently while this one is finalized (e.g. naming, scope).Closes #31