Repository navigation
refactor(cli): run export room and spot through the store - #49
Closed
nichinichisou0609 wants to merge 1 commit into
Closed
nichinichisou0609 wants to merge 1 commit into
nichinichisou0609 wants to merge 1 commit into
Conversation
Two stages export scenes into the store, with subjects a command asks for (the planning fact "requests"): - room.scene: a background key -> room.glb and its room.json report, from the bundles of the key's closure in load order. - spot.scene: a Spot id -> spot.json and its Spine files, from the master tables spot.extract reads and the bundles of the situation key; the bundle names spot.json lists are the task's context. export room writes the scene's glb and report under the name -o gives. export spot places the Spot, its room and the shaders of the background's and situation's closures (unity.export, class Shader), sharing the shader assembly of export shader. TaskCatalog answers resolve for keys whose bundles an extractor only names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the exports are moving to an assembly from per-object results, which covers these commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two stages export scenes into the store. Their subjects are those a command asks for (the planning fact
requests), soexport assetsplans no tasks of them:room.glb(facts:meshCount,inactiveMeshes) and itsroom.jsonreport, from the bundles of the key's closure in load order.spot.json(facts:tapTargets,skeletons) and its Spine files, from the master tablesspot.extractreads and the bundles of the situation key. The bundle namesspot.jsonlists are the task's context, so a renamed bundle gives a new task.export roomwrites the scene and its report under the name-ogives.export spotplaces the Spot, its room and the shaders of the background's and situation's closures (unity.export, classShader), with the shader assembly ofexport shader.TaskCataloganswersresolvefor keys whose bundles an extractor only names.Stacked on #48.
Tests
tests/cli/test_subjects.py:export spoton a synthetic catalog with master tables (the closures the extractors read, the namesspot.jsonlists, the first shader of each name across both closures, the summary), store hits on a second Spot export and onexport roomof its background, and the usage error for a Spot key the catalog lacks.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com