Repository navigation
refactor(cli): run export episode through the store - #50
Closed
nichinichisou0609 wants to merge 1 commit into
Closed
nichinichisou0609 wants to merge 1 commit into
nichinichisou0609 wants to merge 1 commit into
Conversation
The adv.episode stage exports one episode (a MasterAdv id a command asks for) into the store: adv.extract runs through a task catalog that holds the closures of the episode's script and shards and of the ADV player settings, and answers which resource keys exist from the catalog's keys under the prefixes of the episode's resources. A key outside those prefixes leaves the task unchanged; the master tables the extractor reads are inputs. TaskCatalog serves several keys: their closures by stable name, the names resolve lists, the internal ids extractors read and further known keys. The shared stage helpers (master table inputs, closure context, the master directory of a task) are public in modelstages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the exports are moving to an assembly from per-object results, which covers these commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
episode.json(facts:commands,resources).adv.extractruns through a task catalog holding the closures of the episode's script, its-Text,-Sound,-SoundCueSheetand-Videoshards and the ADV player settings. Whether a resource key exists is answered from an input listing the catalog's keys under the prefixes of the episode's resources, so a key outside them leaves the task unchanged.MasterAdv,MasterAdvChatandMasterTextare inputs.TaskCatalogserves several keys: closures by stable name (of_closures), the namesresolvelists, internal ids and further known keys.modelstages.export episodewrites the task's file.Stacked on #49.
Tests
tests/cli/test_subjects.py: what the task catalog answers for the episode's keys, a store hit when an unrelated key is added, a new task when a resource key appears.tests/pipeline/test_modelstages.py: the multi-key task catalog.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com