Repository navigation
refactor(cli): run export live2d, audio and shader through the store - #48
Closed
nichinichisou0609 wants to merge 1 commit into
Closed
nichinichisou0609 wants to merge 1 commit into
nichinichisou0609 wants to merge 1 commit into
Conversation
The single-subject exports of a Live2D model, a cue sheet and the shaders of a key now run their stages through the store over the files the subject's catalog keys load, then copy the subject's artifacts into the output directory. A second export of the same subject is a store hit. - export live2d places the files of the live2d.model task. - export audio runs cri.audio with a new `format` parameter (flac, ogg, wav); its atoms follow the format. Ogg is encoded with ffmpeg's bit-exact flags, so the same samples give the same file. - export shader writes the Shader artifacts of the unity.export tasks of the key's closure; the first shader of each name in load order wins. - shader.safe_name is public; the docs describe the store requirement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the exports are moving to an assembly from per-object results, which covers these commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export live2d,export audioandexport shaderrun the stages of their subject through the store and copy the subject's artifacts into-o:live2d.modeltask of the model key, over the bundles of its closure.cri.audiotask of the cue sheet. The stage gains aformatparameter (flacdefault,ogg,wav); its atoms follow the format (hca.decode, plusflac.encodeorogg.encode). Ogg is encoded with ffmpeg's bit-exact flags, so equal samples give equal files.Shaderartifacts of theunity.exporttasks of the key's closure (or one APK bundle), limited to the classShader. A name met again later in load order keeps its first shader.A second export of the same subject is a store hit.
shader.safe_nameis public. The docs describe the store requirement of these commands and the new stage parameter.Tests
tests/cli/test_subjects.py: each command on synthetic catalogs, including the store hit on a second run and the shader dedupe order.tests/pipeline/test_cristages.py: format normalization, rejected parameters and the files of each format.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com