fix(ux): themed, non-overflowing, mobile-friendly pagination#293
Merged
Conversation
The transactions pagination bar overflowed its card on the right and used hardcoded dark colors + a raw <select>. Rewrite the body (props unchanged): - container: themed `border bg-card`, `flex-wrap min-w-0 gap-3` so the groups reflow instead of spilling off the right edge. - sort toggle: outline Button, icon-only on mobile (label hidden < sm). - page size: shadcn Select (was a native unstyled <select>); same options + reset-to-page-1 behavior. - nav: compact icon-only prev/next (h-9 w-9), muted tabular-nums page indicator; rely on Button's native disabled styling. PaginationProps is unchanged, so both call sites (transactions + DRep list) behave identically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transactions pagination bar (screenshot) overflowed its card on the right, used hardcoded dark
bg-gray-800/900colors off-theme, and a raw unstyled<select>.Change —
pagination.tsxbody only (props unchanged)border-x + shadow-md + p-4→ themedborder bg-card px-3 py-2withflex-wrap min-w-0 gap-3so the three groups reflow to a second row on narrow screens instead of spilling off-screen (the actual overflow fix).outlineButton,size=sm, icon-only on mobile (labelhidden sm:inline). Kept neutral Ascending/Descending (the DRep list is a Blockfrostorder=asc|descparam, not time-sorted).<select>→ shadcnSelect; identical options + reset-to-page-1.h-9 w-9),tabular-numsmuted page indicator; nativedisabled:styling.PaginationPropsis byte-for-byte unchanged, so both call sites (all-transactions.tsx,homepage/governance/drep/index.tsx) compile and behave identically.Verify
tscclean;jest362 passed.Part of the transactions-UI redesign (synthesized via a map→design→judge workflow). Follow-ups: row information-hierarchy flip + section/balance polish.
🤖 Generated with Claude Code