fix(ux): lead transaction rows with the label, demote the hash#294
Merged
Conversation
The on-chain history rows (desktop table + mobile cards) led with the raw
truncated tx hash — the least human-meaningful field — while the actual
description ("Ballot Vote: …") was buried below. Flip the hierarchy to match
the pending-tx cards:
- primary: the dbTransaction description, or a "Sent"/"Received" fallback (and
the cert label on desktop) so rows without a DB record aren't identified by
a bare hash.
- date below.
- hash demoted to a quiet muted mono link with the external-link arrow.
Also standardize the hash truncation on getFirstAndLast(hash, 8, 8) (was two
different inline substring schemes) and drop the now-redundant standalone
description block on mobile. Cardanoscan links, outputs, certs, signers, and
the row actions menu are unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of the transactions-UI redesign (after #293 pagination).
The on-chain history rows (desktop table + mobile cards) led with the raw truncated tx hash — the least human-meaningful field — while the actual description ("Ballot Vote: …") was buried below. The pending-tx cards already lead with the description; this brings history in line.
Changes (
all-transactions.tsx,responsive-transactions-table.tsx)dbTransaction.description, falling back to the cert label (desktop) or "Sent"/"Received" so rows without a DB record aren't identified by a bare hash.getFirstAndLast(hash, 8, 8)(was two inlinesubstringschemes); drop the now-redundant standalone description block on mobile.Cardanoscan links, outputs, certs, signers, and the kebab actions menu are unchanged.
Verify
tscclean;jest362 passed.🤖 Generated with Claude Code