Skip to content

Route foreground commands through ACP client terminals - #155

Closed
Maximooch wants to merge 1 commit into
feat/acp-client-filesfrom
feat/acp-client-terminals
Closed

Maximooch wants to merge 1 commit into
feat/acp-client-filesfrom
feat/acp-client-terminals

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Change

Clients advertising terminal RPCs can explicitly enable client_terminal=client after opting into client file mode. Select cmd, PowerShell or POSIX sh. Native and legacy commands then use client create/wait/output/release, bounded output/deadlines and native terminal cards. Cancel/timeout attempts kill and release, including a late create reply; cleanup failures are reported. Only explicit validated env overrides are sent, never host env.

Depends on #154; no PRs merged. This is foreground command support: client background handles, yielding and stdin are deliberately not advertised. Local managed processes remain available in local mode. Client file mode still rejects local code/process execution, preventing accidental hybrid workspaces.

Validation and active dependency

  • Terminal tests cover native/legacy calls, actual CLI stdio lifecycle, no local execution, timeout, cancel during create/wait, cleanup failure reporting, Plan denial and capability checks.
  • Latest full run:109 passed/1 failed. The failure is a reproduced native Windows SessionManager atomic-save WinError5 during rapid config changes, before command execution. An independent reliability follow-up is fixing store durability; this draft awaits that dependency and final revalidation.
  • ACP/new-module/test Ruff and diff checks pass. New suite is included in four-OS/Python ACP CI matrix.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 6:18am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — a52a8725 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant