[Maximooch]

Problem and fix

Real permission prompts were rejected by the SDK before reaching the client: RequestPermissionRequest.tool_call expects ToolCallUpdate, but the adapter passed ToolCallStart. That silently became a denied tool result. Pass the required snapshot type, without the sessionUpdate discriminator.

Both real CLI allow/deny cases reproduce with zero permission RPCs before the fix and pass afterward. Existing mocks did not enforce this SDK boundary.

Depends on #155 in the review stack; the underlying issue affects earlier adapter versions too. No PRs merged.

Validation

6 permission-wire/child-approval tests pass on Windows Python 3.11, including real subprocess CLI and actual file-tool dispatch. Ruff/diff checks pass. Added to ACP CI. The independent native Windows session-store durability issue remains tracked separately.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
penguin	Ready	Preview	Oct 28, 2026 6:22am UTC

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Maximooch]

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.