Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Clients advertising both text-file RPCs can explicitly choose file_access=client. Read/write tools use editor buffers through ACP after normal permission checks; local remains default. Other filesystem tools and local shell/code tools are hidden and rejected in client-FS mode, preventing accidental hybrid operations. No silent local fallback. Native and legacy XML text-file actions use the async dispatch path. Persist the choice, reject reload when the next client lacks support, bound content and validate paths.
Depends on #153. No PRs merged. Client mode requires the same canonical workspace paths and the client's own filesystem authorization. Fully remote virtual directories remain separate. ACP text writes provide no backup or atomic-edit contract, so explicit backup requests fail. Terminal routing follows separately.
Validation
103 ACP/edit-contract tests passed on Windows Python 3.11; four focused tests also cover opt-in default, cross-session isolation, unsaved client buffers, native and legacy file calls, Plan denial, unsupported operations, cancelled write with no success acknowledgement, persisted mode/capability mismatch, and actual CLI stdio read/write roundtrip. Ruff on ACP/new provider/tests and diff checks pass. Dedicated ACP CI includes the new suite.