Repository navigation
#4880 Ship Csla.Avalonia with the framework packages - #4906
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NW2FoBK5ogTPJam3vmMmyZ
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NW2FoBK5ogTPJam3vmMmyZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #4880.
#4887 added
Csla.Xaml.Avalonia, but that project was only in its own solution. It wasn't incsla.build.sln, soCsla.Avaloniawould not have been packed or published with 10.2.0-beta.1.Framework packaging
Csla.Xaml.Avaloniatocsla.build.slnunder the UI folder. The release workflow packs this solution.csla.test.slnas well, since CI only builds that solution.Csla.Xaml.Avalonia.csprojwith the other packaged projects such asCsla.WpfandCsla.Blazor:Cslaproject. Release builds previously used theCsla10.0.0 NuGet package, a setup copied from MAUI, which is released separately. The package would have depended on Csla 10.0.0 instead of the matching version.SignAssembly,BaseOutputPath,ProductandDescription.Directory.Build.propsalready provides, and switches to 2-space indentation.Avalonia sample
The sample referenced
Source/Csla.Xaml.Avaloniadirectly. That pulled framework projects into its build and failed with CS7027, because the signing key path depends on the solution directory. It now matchesWpfExample:Directory.Packages.propsfor central package management, withCslaVersionandAvaloniaVersionproperties.Csla.Avaloniapackage instead of the source project.CslaVersionis set to10.2.0-beta.1, so the sample won't restore from nuget.org until that beta is published. Until then, pointCslaVersionat a locally packed build.Verification
dotnet pack Source/csla.build.sln -c Release -p:PublicRelease=trueproducesCsla.Avalonia.10.2.0-beta.1.nupkg:Csla.Wpf: license, icon, readme, repository commit, tags, and XML docs and pdb inlib.Csla 10.2.0-beta.1andAvalonia 12.1.1.Csla.Xaml.dllis strong-named with the same key asCsla.Wpf(PublicKeyToken=93be5fdc093e4c30).-owritesCsla.Avaloniatobin/packagesalong with the other packages.dotnet build Source/csla.test.slnbuilds with 0 errors.CslaandCsla.Avaloniaas packages, builds, and passes its headless test (1/1).Not changed
Csla.Analyzerspacks toBin/Releaseinstead ofbin/packages, because it doesn't importDirectory.Package.props. That behavior predates this PR. The analyzers ship inside theCslapackage, and moving this one would publish a standalone package at the next release.🤖 Generated with Claude Code
https://claude.ai/code/session_01NW2FoBK5ogTPJam3vmMmyZ