Skip to content

Export Filler Name as a list #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Seatori wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Export Filler Name as a list #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
005fdaf
Export filler_item_name as a list
Seatori Jul 8, 2026
d1a6dd4
Change importing filler_item_name lists to separate the names with sp…
Seatori Jul 8, 2026
941846c
Add an example conveying that Filler Name accepts a list of names
Seatori Jul 8, 2026
65065db
Pluralize Filler Name
Seatori Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
</div>
<div class="input-group">
<label for="filler">
Filler Name:
Filler Names:
<i class="bi bi-info-circle-fill" :data-bs-title="Tooltips['SIDEBAR_FILLER_NAME']" data-bs-toggle="tooltip" data-bs-html="true"></i>
</label>
<input type="text" v-model.lazy="filler" :placeholder="Examples['SIDEBAR_FILLER_NAME']" />
Expand Down
2 changes: 1 addition & 1 deletion js/exporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class Exporter {
"$schema": "https://github.com/ManualForArchipelago/Manual/raw/main/schemas/Manual.game.schema.json",
'game': this.vue.game.replace(/[^A-Za-z0-9]/g, ''),
'creator': this.vue.creator.replace(/[^A-Za-z0-9]/g, ''),
'filler_item_name': this.vue.filler,
'filler_item_name': this.vue.filler?.split(',').map((r) => r.trim()) || [],
'starting_items': this.vue.starting_items,
});

Expand Down
8 changes: 7 additions & 1 deletion js/importer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,13 @@ export class Importer {
this.vue.creator = this.game.player;
}

this.vue.filler = this.game.filler_item_name;
if (typeof this.game.filler_item_name === "string") {
this.vue.filler = this.game.filler_item_name;
}
else {
this.vue.filler = this.game.filler_item_name?.join(', ') || '';
}

this.vue.starting_items = this.game.starting_items || [];
}

Expand Down
2 changes: 1 addition & 1 deletion text/examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const Examples = {
SIDEBAR_GAME: "",
SIDEBAR_CREATOR: "your name, probably",
SIDEBAR_FILLER_NAME: "",
SIDEBAR_FILLER_NAME: "Filler 1, Filler 2, etc.",

ITEMS_NAME: "",
ITEMS_CATEGORIES: "Category 1, Category 2, etc.",
Expand Down