Export Filler Name as a list - #29
Draft
Seatori wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ManualForArchipelago/Manual#223, and depends on it to work properly.
This changes Filler Name to export as a list instead of a string, and splits item names with commas to create each entry in the list, in the same way that Categories and Connects To are exported.
Filler Namehas also been renamed toFiller Names, and a syntax example has been added, in an attempt to convey the function to users.I am not familiar with JavaScript so I just copied code from elsewhere in the website that did the same thing as what I wanted. I did some light testing with exporting and importing different combinations of lists and strings and could not find any issues.