chore: init hackathon codebase - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup of the hackathon codebase by removing comments and duplicate gitignore entries in preparation for the hackathon event.
Changes:
- Removed Korean language comments and TODO notes from the Kubernetes ingress configuration
- Removed host specification from ingress rules to allow matching all hosts
- Cleaned up duplicate entries in
.gitignore
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/k8s/application/07-ingress.yaml | Removed comments, host specification, and commented-out TLS configuration to simplify the ingress setup |
| .gitignore | Removed duplicate entries for k8s-secrets.env and .env |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| rules: | ||
| - host: tva.example.com # TODO: 실제 도메인으로 변경 | ||
| http: | ||
| - http: |
There was a problem hiding this comment.
Removing the host specification makes this ingress match all hosts, which could be a security concern in production environments. Without a specific host, any domain pointing to this cluster will be routed to these services. Consider keeping a host specification or using a wildcard pattern that matches your expected domain(s).
Suggested change
| - http: | |
| - host: "tva.example.com" # TODO: replace with the actual expected host or wildcard domain | |
| http: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.