feat(k8s): add k8s - #10
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds Kubernetes configuration enhancements to the backend deployment, specifically adding support for pulling private container images from GitHub Container Registry and fixing a port configuration inconsistency.
Changes:
- Added
imagePullSecretsconfiguration to enable pulling the backend image from GitHub Container Registry (ghcr.io) - Fixed service port mismatch by changing from 8001 to 8000 to align with the container's targetPort
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -18,6 +18,8 @@ spec: | |||
| labels: | |||
| app: backend | |||
| spec: | |||
There was a problem hiding this comment.
The imagePullSecrets field references a secret named 'ghcr-pull', but there is no documentation or accompanying secret manifest explaining how to create this secret. Consider adding documentation (e.g., in a README or comment) with instructions on how to create the ghcr-pull secret, such as:
kubectl create secret docker-registry ghcr-pull --docker-server=ghcr.io --docker-username= --docker-password= --namespace=tva
This will help operators deploying this configuration understand the prerequisites.
| spec: | |
| spec: | |
| # ghcr.io에서 이미지를 가져오기 위한 imagePullSecret 필요 | |
| # 사전 준비: | |
| # kubectl create secret docker-registry ghcr-pull \ | |
| # --docker-server=ghcr.io \ | |
| # --docker-username=<username> \ | |
| # --docker-password=<token> \ | |
| # --namespace=tva |
No description provided.