Skip to content

force: Vault NonceManagerKind::Safe for aggregator #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ueco-jb merged 3 commits into from
May 25, 2026
Merged

force: Vault NonceManagerKind::Safe for aggregator #1152

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fef292
force: NonceManagerKind::Safe
May 23, 2026
f749de5
Fix fmt
ueco-jb May 25, 2026
326abcc
Merge branch 'main' into 2.0.0-vault
ueco-jb May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions packages/wavs/src/subsystems/aggregator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ use std::{
use layer_climb::prelude::*;
use tracing::instrument;
use utils::{
async_transaction::AsyncTransaction, config::EvmChainConfigExt, context::AppContext,
evm_client::EvmSigningClient, storage::db::WavsDb, telemetry::AggregatorMetrics,
async_transaction::AsyncTransaction,
config::EvmChainConfigExt,
context::AppContext,
evm_client::{EvmSigningClient, NonceManagerKind},
storage::db::WavsDb,
telemetry::AggregatorMetrics,
};
use wavs_engine::bindings::aggregator::world::AnyTxHash;
use wavs_types::{
Expand Down Expand Up @@ -728,7 +732,16 @@ impl Aggregator {
}
};

let client_config = chain_config.signing_client_config(credential.clone())?;
let mut client_config = chain_config.signing_client_config(credential.clone())?;
// [vault patch 2.0.0-vault.1] Force SafeNonceManager for on-chain submissions.
// The default FastNonceManager caches an in-memory nonce counter that increments on
// every send attempt (including failures) and only re-seeds from chain at client
// construction. A sustained run of failed sends (e.g. gas exhaustion) desyncs it far
// past the on-chain nonce and wedges submission until the process is restarted.
// SafeNonceManager queries the chain nonce per send, removing that failure mode.
// Submissions are already serialized per-chain (chain_transaction), so there is no
// concurrent-tx nonce-collision risk. Cost: one extra eth_getTransactionCount per tx.
client_config.nonce_manager_kind = NonceManagerKind::Safe;

let client = EvmSigningClient::new(client_config)
.await
Expand Down
Loading